UNCLASSIFIED - NO CUI

registryCredentials should not be required

Feature Request

Why

The RegistryCredential should not be required to be set in the chart. This is because using a Cloud OCI registry, credentials may not be needed. OIDC auth may be used to pull the images. It does continue to function, because the credential is used first and fails. Then Kubernetes tries again and succeeds.

Error Message: bigbang:\n- (root): registryCredentials is required\n\n

Proposed Solution

Remove the requirement for Registry Credentials, and make them optional.

Testing ( michael )

Using a local image repo, I set it up so password/login is not required.

Testing involved installing all packages with and without setting registryCredentials. All serviceAccount and pods were parsed for any occurrences of private-registry.

Notes

Some upstream packages use the concept of a common value for the imagePullSecret. This value is generally looked at as a default value. Then, individual containers might offer a way to override this default. As upstream packages have migrated over to a commmon value, we may still have our packages override the common values which is unnecessary ( e.g. gitlab ). I've created an update to gitlab to use the common pattern, as gitlab overrode the common value excessively. Other package fixes to support common or clean up overrides will be done outside this issue.

Edited by Michael Martin