From 56660d2567a63b727e0e6273377d2eb57f1277d8 Mon Sep 17 00:00:00 2001
From: Michael Martin <michaelmartin@seed-innovations.com>
Date: Thu, 6 Mar 2025 11:36:03 -0700
Subject: [PATCH] fix cypress tests .  use data-testid for hopeful stability

---
 CHANGELOG.md                                       | 5 +++++
 README.md                                          | 3 ++-
 chart/Chart.yaml                                   | 2 +-
 chart/tests/cypress/e2e/01-run-pipeline.spec.cy.js | 3 ++-
 4 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7989d69..e0e64ee 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,11 @@
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 
+## [0.73.0-bb.1] - 2025-03-06
+### Changed
+
+- Changed cypress test to use  data-testid
+
 ## [0.73.0-bb.0] - 2025-01-22
 
 ### Changed
diff --git a/README.md b/README.md
index da1937b..920ffac 100644
--- a/README.md
+++ b/README.md
@@ -1,7 +1,7 @@
 <!-- Warning: Do not manually edit this file. See notes on gluon + helm-docs at the end of this file for more information. -->
 # gitlab-runner
 
-![Version: 0.73.0-bb.0](https://img.shields.io/badge/Version-0.73.0--bb.0-informational?style=flat-square) ![AppVersion: 17.8.0](https://img.shields.io/badge/AppVersion-17.8.0-informational?style=flat-square) ![Maintenance Track: bb_integrated](https://img.shields.io/badge/Maintenance_Track-bb_integrated-green?style=flat-square)
+![Version: 0.73.0-bb.1](https://img.shields.io/badge/Version-0.73.0--bb.1-informational?style=flat-square) ![AppVersion: 17.8.0](https://img.shields.io/badge/AppVersion-17.8.0-informational?style=flat-square) ![Maintenance Track: bb_integrated](https://img.shields.io/badge/Maintenance_Track-bb_integrated-green?style=flat-square)
 
 GitLab Runner
 
@@ -62,6 +62,7 @@ helm install gitlab-runner chart/
 | sessionServer.ingress.enabled | bool | `false` |  |
 | sessionServer.ingress.className | string | `""` |  |
 | sessionServer.ingress.annotations | object | `{}` |  |
+| sessionServer.ingress.tls[0].secretName | string | `"gitlab-runner-session-server"` |  |
 | rbac.create | bool | `true` |  |
 | rbac.generatedServiceAccountName | string | `""` |  |
 | rbac.rules | list | `[]` |  |
diff --git a/chart/Chart.yaml b/chart/Chart.yaml
index 54de61f..43b4ca1 100644
--- a/chart/Chart.yaml
+++ b/chart/Chart.yaml
@@ -1,6 +1,6 @@
 apiVersion: v2
 name: gitlab-runner
-version: 0.73.0-bb.0
+version: 0.73.0-bb.1
 appVersion: 17.8.0
 description: GitLab Runner
 keywords:
diff --git a/chart/tests/cypress/e2e/01-run-pipeline.spec.cy.js b/chart/tests/cypress/e2e/01-run-pipeline.spec.cy.js
index 205ff0b..03823e9 100644
--- a/chart/tests/cypress/e2e/01-run-pipeline.spec.cy.js
+++ b/chart/tests/cypress/e2e/01-run-pipeline.spec.cy.js
@@ -35,7 +35,8 @@ describe('Gitlab Runner: Run Pipeline', () => {
       cy.get('div[class="view-line"]').click().type('pipeline-test:{enter}{backspace}  stage: test{enter}{backspace}  script:{enter}{backspace}{backspace}    - echo The pipeline test is successful!{enter}')
       // commit file and start pipeline
       cy.scrollTo('bottom')
-      cy.get('button[id="commit-changes"]').click()
+      cy.get('button[data-testid="blob-edit-header-commit-button"]').click()
+      cy.get('button[data-testid="commit-change-modal-commit-button').click()
     })
     // Go to pipelines page
     cy.url().should('eq', `${Cypress.env('url')}/root/${Cypress.env('gitlab_project')}/-/blob/main/.gitlab-ci.yml`) 
-- 
GitLab