complete Gitlab istio injection for upgrade jobs

upgrade jobs

k8s jobs that run and then complete have difficulty with istio injection because the istio sidecar container stays alive and prevents the pod from finishing. Fix the upgrade jobs script to kill the istio sidecar at the end of the script.

Reference original istio injection MR

https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/merge_requests/91

upgrade check job

chart/templates/upgrade_check_hook.yaml
chart/templates/_runcheck.tpl
remove istio injection false annotation
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/blob/main/chart/templates/upgrade_check_hook.yaml#L38-41

rolling upgrade job

Delete the rolling upgrade job files. We will get rid of this job.
chart/templates/bigbang/rolling-upgrade/rolling_upgrade.yaml
chart/templates/bigbang/rolling-upgrade/_rolling-upgrade-script.tpl

Here are some examples how to fix:

https://repo1.dso.mil/platform-one/big-bang/apps/core/monitoring/-/blob/main/chart/templates/prometheus-operator/admission-webhooks/job-patch/job-createSecret.yaml#L48-L57
https://repo1.dso.mil/platform-one/big-bang/apps/core/elasticsearch-kibana/-/merge_requests/69/diffs#5b7174495e64650927423aa9b1b61a6c8bea073c_133_132

Testing

To test you need to first deploy an older version of Gitlab and then deploy a newer version.