Additional requested changes to support pass through
-
Remove README.md.gotmpl This file will now be included in the tempo chart bundle - Removed -
Remove README.md as that will also go stale now that we no longer maintain it - Removed -
update istio custom resources to use v1 instead of v1beta1 - Updated to v1 -
change pullPolicy to always to align with Big Bang standard - Changed to Always -
Does not appear that the serviceMonitor fields of scheme and tlsConfig that we provide are included upstream. These may have been changes we made from upstream? They have no templated use as of now. Do we know why the scheme and tlsConfig was added? i see it was referenced in dev maintenance. I think this fixed a bug with the service monitor and istio potentially? Can we validate that it still works? - Removed, I don't see this pattern implemented elsewhere -
evaluate should we be setting persistence to enabled by default? Noticing the upstream project does not, is our configuration expected to serve as a production configuration? or just for dev/test? If dev/test, should this belong in our test-values instead? Not saying one way or the other... Just thinking it through - Agreed, removed persistence in package default values.yaml, updated the test-values.yaml to include persistence for tempo -
how do we feel about these default resource requests and limits? Do we think we need CPU requests/limits by default? - Kept Requests, Removed Limits -
Update to latest gluon 9.x version - Updated to 9.0.1 -
Haven't been able to find where the objectStorage values are passed to. Remove if not used at package layer. I don't see it in the upstream chart but i didn't dig.- Removed from values.yaml as this Big Bang Postrenderer handles the secret reference
Edited by Kirby Liu