From c8ffb0f5eb3add0dc7aba3fb834df2344e36e3e6 Mon Sep 17 00:00:00 2001 From: Jacob Ortiz <jacobortiz@SpaceCAMP213.local> Date: Fri, 29 Apr 2022 14:15:43 -0400 Subject: [PATCH 1/5] updating issues templates for labels and process changes --- .gitlab/issue_templates/Application - Initial.md | 6 +++--- .gitlab/issue_templates/Application - Update.md | 9 ++------- .gitlab/issue_templates/Onboarding Question.md | 5 +++-- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/.gitlab/issue_templates/Application - Initial.md b/.gitlab/issue_templates/Application - Initial.md index 4a0aa70..7a5f6a3 100644 --- a/.gitlab/issue_templates/Application - Initial.md +++ b/.gitlab/issue_templates/Application - Initial.md @@ -9,7 +9,7 @@ Contributor: - [ ] Ensure container builds successfully in the Iron Bank pipeline - [ ] Provide justifications for findings in the [VAT](https://vat.dso.mil) ([docs](https://repo1.dso.mil/dsop/dccscr/-/blob/master/pre-approval/vat.md)) - [ ] Open a Merge Request from your branch to `development` -- [ ] Apply the ~"Approval" label to this issue and wait for feedback +- [ ] Apply the ~"Hardening::Review" label to this issue and wait for feedback Iron Bank: - [ ] Merge contributor branch to `development` @@ -17,7 +17,7 @@ Iron Bank: - [ ] Send approval request to Authorizing Official - [ ] Merge `development` to `master` and close issue after approval from Authorizing Official -> Note: If the above approval process is rejected for any reason, the `Approval` label will be removed and the issue will be sent back to `Open`. Any comments will be listed in this issue for you to address. Once they have been addressed, you **must** re-add the `Approval` label. +> Note: If the above approval process is rejected for any reason, the `Hardening::Approval` label will be removed and the issue will be sent back to `Open`. Any comments will be listed in this issue for you to address. Once they have been addressed, you **must** re-add the `Hardening::Approval` label. ## Questions? @@ -26,7 +26,7 @@ Contact the Iron Bank team by commenting on this issue with your questions or co Additionally, Iron Bank hosts an [AMA](https://www.zoomgov.com/meeting/register/vJIsf-ytpz8qHSN_JW8Hl9Qf0AZZXSCSmfo) working session every Wednesday from 1630-1730EST to answer questions. - +/label ~"Container::Initial" diff --git a/.gitlab/issue_templates/Application - Update.md b/.gitlab/issue_templates/Application - Update.md index a411b82..b08c757 100644 --- a/.gitlab/issue_templates/Application - Update.md +++ b/.gitlab/issue_templates/Application - Update.md @@ -11,7 +11,7 @@ Contributor: - [ ] Ensure container builds successfully in the Iron Bank pipeline - [ ] Provide justifications for findings in the [VAT](https://vat.dso.mil) ([docs](https://repo1.dso.mil/dsop/dccscr/-/blob/master/pre-approval/vat.md)) - [ ] Open a Merge Request from your branch to `development` -- [ ] Apply the ~"Approval" label to this issue and wait for feedback +- [ ] Apply the ~"Hardening::Approval" label to this issue and wait for feedback Iron Bank: - [ ] Merge contributor branch to `development` @@ -19,7 +19,7 @@ Iron Bank: - [ ] Send approval request to Authorizing Official - [ ] Merge `development` to `master` and close issue after approval from Authorizing Official -> Note: If the above approval process is rejected for any reason, the `Approval` label will be removed and the issue will be sent back to `Open`. Any comments will be listed in this issue for you to address. Once they have been addressed, you **must** re-add the `Approval` label. +> Note: If the above approval process is rejected for any reason, the `Hardening::Approval` label will be removed and the issue will be sent back to `Open`. Any comments will be listed in this issue for you to address. Once they have been addressed, you **must** re-add the `Hardening::Approval` label. ## Questions? @@ -28,9 +28,4 @@ Contact the Iron Bank team by commenting on this issue with your questions or co Additionally, Iron Bank hosts an [AMA](https://www.zoomgov.com/meeting/register/vJIsf-ytpz8qHSN_JW8Hl9Qf0AZZXSCSmfo) working session every Wednesday from 1630-1730EST to answer questions. - - - - - /label ~"Container::Update" diff --git a/.gitlab/issue_templates/Onboarding Question.md b/.gitlab/issue_templates/Onboarding Question.md index ae8011e..8dd13f1 100644 --- a/.gitlab/issue_templates/Onboarding Question.md +++ b/.gitlab/issue_templates/Onboarding Question.md @@ -8,5 +8,6 @@ -/label ~"Question::Onboarding" ~"To Do" -/cc @ironbank-notifications/onboarding \ No newline at end of file +/label ~"Question::Onboarding" ~"CSO::To Do" +/cc @ironbank-notifications/onboarding +/assign @ironbank-notifications/onboarding \ No newline at end of file -- GitLab From e00b6bfb201ec21672348298bf0a09063fe03c50 Mon Sep 17 00:00:00 2001 From: Jacob Ortiz <jacobortiz@SpaceCAMP213.local> Date: Fri, 29 Apr 2022 14:33:21 -0400 Subject: [PATCH 2/5] fixing mistakes --- .gitlab/issue_templates/Access Request.md | 16 ++++++++++------ .gitlab/issue_templates/Application - Initial.md | 4 ---- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.gitlab/issue_templates/Access Request.md b/.gitlab/issue_templates/Access Request.md index b9fd83b..257233b 100644 --- a/.gitlab/issue_templates/Access Request.md +++ b/.gitlab/issue_templates/Access Request.md @@ -2,18 +2,22 @@ The following individuals are requesting access to this project (one per line): (Tag all individuals here) + - Tag here The access level should be: - [ ] Developer access - [ ] Remove access +Dose the member need access to the VAT? (https://vat.dso.mil/vat) +- [ ] Yes +- [ ] No -## Definition of Done -- [ ] All accounts have been provided the necessary accesses - - - +## Iron Bank Tasks +- [ ] All accounts have been provided the necessary accesses to the projects +- [ ] All accounts have been provided the necessary accesses to the VAT (optional) -/label ~"Access Request" ~"To Do" ~"Owner::Ironbank" +/label ~"Access Request::Repo" ~"CSO::To Do" ~"Owner::Ironbank" +/cc @ironbank-notifications/onboarding +/assign @ironbank-notifications/onboarding \ No newline at end of file diff --git a/.gitlab/issue_templates/Application - Initial.md b/.gitlab/issue_templates/Application - Initial.md index 7a5f6a3..0c90d41 100644 --- a/.gitlab/issue_templates/Application - Initial.md +++ b/.gitlab/issue_templates/Application - Initial.md @@ -28,7 +28,3 @@ Additionally, Iron Bank hosts an [AMA](https://www.zoomgov.com/meeting/register/ /label ~"Container::Initial" - - - -/label ~"Container::Initial" -- GitLab From 0a37ae4cff5a35fff4fc4e8d981568a24ea34e78 Mon Sep 17 00:00:00 2001 From: Adam Martin <adam.martin@rancherfederal.com> Date: Fri, 29 Apr 2022 19:23:18 +0000 Subject: [PATCH 3/5] Apply 1 suggestion(s) to 1 file(s) --- .gitlab/issue_templates/Access Request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/issue_templates/Access Request.md b/.gitlab/issue_templates/Access Request.md index 257233b..d62d3fb 100644 --- a/.gitlab/issue_templates/Access Request.md +++ b/.gitlab/issue_templates/Access Request.md @@ -9,7 +9,7 @@ The access level should be: - [ ] Developer access - [ ] Remove access -Dose the member need access to the VAT? (https://vat.dso.mil/vat) +Does the member need access to the VAT? (https://vat.dso.mil/vat) - [ ] Yes - [ ] No -- GitLab From 34e5ea07977745ab120275847d375a438c472704 Mon Sep 17 00:00:00 2001 From: David Freeman <davidfreeman@seed-innovations.com> Date: Wed, 11 May 2022 19:19:47 +0000 Subject: [PATCH 4/5] Update label --- .gitlab/issue_templates/Application - Update.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab/issue_templates/Application - Update.md b/.gitlab/issue_templates/Application - Update.md index b08c757..69d6d95 100644 --- a/.gitlab/issue_templates/Application - Update.md +++ b/.gitlab/issue_templates/Application - Update.md @@ -11,7 +11,7 @@ Contributor: - [ ] Ensure container builds successfully in the Iron Bank pipeline - [ ] Provide justifications for findings in the [VAT](https://vat.dso.mil) ([docs](https://repo1.dso.mil/dsop/dccscr/-/blob/master/pre-approval/vat.md)) - [ ] Open a Merge Request from your branch to `development` -- [ ] Apply the ~"Hardening::Approval" label to this issue and wait for feedback +- [ ] Apply the ~"Hardening::Review" label to this issue and wait for feedback Iron Bank: - [ ] Merge contributor branch to `development` -- GitLab From 641283f5e35a745c95db3f7dc30afd7723cbf4de Mon Sep 17 00:00:00 2001 From: Joe Roberts <jroberts@rackner.com> Date: Mon, 17 Oct 2022 11:46:21 -0500 Subject: [PATCH 5/5] Remove issue templates --- .gitlab/issue_templates/Access Request.md | 23 ----------- .../issue_templates/Application - Archive.md | 23 ----------- .../issue_templates/Application - Initial.md | 30 -------------- .../issue_templates/Application - Update.md | 31 -------------- .gitlab/issue_templates/Bug.md | 41 ------------------- .gitlab/issue_templates/Feature Request.md | 36 ---------------- .../issue_templates/Leadership Question.md | 12 ------ .gitlab/issue_templates/New Findings.md | 30 -------------- .../issue_templates/Onboarding Question.md | 13 ------ .gitlab/issue_templates/Pipeline Failure.md | 36 ---------------- 10 files changed, 275 deletions(-) delete mode 100644 .gitlab/issue_templates/Access Request.md delete mode 100644 .gitlab/issue_templates/Application - Archive.md delete mode 100644 .gitlab/issue_templates/Application - Initial.md delete mode 100644 .gitlab/issue_templates/Application - Update.md delete mode 100644 .gitlab/issue_templates/Bug.md delete mode 100644 .gitlab/issue_templates/Feature Request.md delete mode 100644 .gitlab/issue_templates/Leadership Question.md delete mode 100644 .gitlab/issue_templates/New Findings.md delete mode 100644 .gitlab/issue_templates/Onboarding Question.md delete mode 100644 .gitlab/issue_templates/Pipeline Failure.md diff --git a/.gitlab/issue_templates/Access Request.md b/.gitlab/issue_templates/Access Request.md deleted file mode 100644 index d62d3fb..0000000 --- a/.gitlab/issue_templates/Access Request.md +++ /dev/null @@ -1,23 +0,0 @@ -## Summary - -The following individuals are requesting access to this project (one per line): -(Tag all individuals here) - -- Tag here - -The access level should be: -- [ ] Developer access -- [ ] Remove access - -Does the member need access to the VAT? (https://vat.dso.mil/vat) -- [ ] Yes -- [ ] No - -## Iron Bank Tasks -- [ ] All accounts have been provided the necessary accesses to the projects -- [ ] All accounts have been provided the necessary accesses to the VAT (optional) - - -/label ~"Access Request::Repo" ~"CSO::To Do" ~"Owner::Ironbank" -/cc @ironbank-notifications/onboarding -/assign @ironbank-notifications/onboarding \ No newline at end of file diff --git a/.gitlab/issue_templates/Application - Archive.md b/.gitlab/issue_templates/Application - Archive.md deleted file mode 100644 index 0304276..0000000 --- a/.gitlab/issue_templates/Application - Archive.md +++ /dev/null @@ -1,23 +0,0 @@ -## Summary - -Requesting this application be archived due to one of the following reasons: -- [ ] Version is no longer supported by vendor -- [ ] Application is End-Of-Life -- [ ] License violation. -- [ ] Other. See below. - -## Detailed Description - -(Please provide a detailed description of why this application should be archived) - - -## Definition of Done -- [ ] Application has been reviewed for archival -- [ ] Project is officially marked as stale -- [ ] Iron Bank frontend no longer lists application as available or approved - - - - - -/label ~"Container::Archive" \ No newline at end of file diff --git a/.gitlab/issue_templates/Application - Initial.md b/.gitlab/issue_templates/Application - Initial.md deleted file mode 100644 index 0c90d41..0000000 --- a/.gitlab/issue_templates/Application - Initial.md +++ /dev/null @@ -1,30 +0,0 @@ -## Summary - -Request for a new application in Iron Bank. - -## Tasks - -Contributor: -- [ ] Add `Dockerfile`, `hardening_manifest.yaml` and adhere to Iron Bank [requirements](https://repo1.dso.mil/dsop/dccscr/-/tree/master/Hardening) -- [ ] Ensure container builds successfully in the Iron Bank pipeline -- [ ] Provide justifications for findings in the [VAT](https://vat.dso.mil) ([docs](https://repo1.dso.mil/dsop/dccscr/-/blob/master/pre-approval/vat.md)) -- [ ] Open a Merge Request from your branch to `development` -- [ ] Apply the ~"Hardening::Review" label to this issue and wait for feedback - -Iron Bank: -- [ ] Merge contributor branch to `development` -- [ ] Review findings and justifications -- [ ] Send approval request to Authorizing Official -- [ ] Merge `development` to `master` and close issue after approval from Authorizing Official - -> Note: If the above approval process is rejected for any reason, the `Hardening::Approval` label will be removed and the issue will be sent back to `Open`. Any comments will be listed in this issue for you to address. Once they have been addressed, you **must** re-add the `Hardening::Approval` label. - -## Questions? - -Contact the Iron Bank team by commenting on this issue with your questions or concerns. If you do not receive a response, add `/cc @ironbank-notifications/onboarding`. - -Additionally, Iron Bank hosts an [AMA](https://www.zoomgov.com/meeting/register/vJIsf-ytpz8qHSN_JW8Hl9Qf0AZZXSCSmfo) working session every Wednesday from 1630-1730EST to answer questions. - - -/label ~"Container::Initial" - diff --git a/.gitlab/issue_templates/Application - Update.md b/.gitlab/issue_templates/Application - Update.md deleted file mode 100644 index 69d6d95..0000000 --- a/.gitlab/issue_templates/Application - Update.md +++ /dev/null @@ -1,31 +0,0 @@ -## Summary - -Request to update an application in Iron Bank. - -Version: (State the version you would like the application updated to) - -## Tasks - -Contributor: -- [ ] Update `Dockerfile`, `hardening_manifest.yaml` and adhere to Iron Bank [requirements](https://repo1.dso.mil/dsop/dccscr/-/tree/master/Hardening) -- [ ] Ensure container builds successfully in the Iron Bank pipeline -- [ ] Provide justifications for findings in the [VAT](https://vat.dso.mil) ([docs](https://repo1.dso.mil/dsop/dccscr/-/blob/master/pre-approval/vat.md)) -- [ ] Open a Merge Request from your branch to `development` -- [ ] Apply the ~"Hardening::Review" label to this issue and wait for feedback - -Iron Bank: -- [ ] Merge contributor branch to `development` -- [ ] Review findings and justifications -- [ ] Send approval request to Authorizing Official -- [ ] Merge `development` to `master` and close issue after approval from Authorizing Official - -> Note: If the above approval process is rejected for any reason, the `Hardening::Approval` label will be removed and the issue will be sent back to `Open`. Any comments will be listed in this issue for you to address. Once they have been addressed, you **must** re-add the `Hardening::Approval` label. - -## Questions? - -Contact the Iron Bank team by commenting on this issue with your questions or concerns. If you do not receive a response, add `/cc @ironbank-notifications/onboarding`. - -Additionally, Iron Bank hosts an [AMA](https://www.zoomgov.com/meeting/register/vJIsf-ytpz8qHSN_JW8Hl9Qf0AZZXSCSmfo) working session every Wednesday from 1630-1730EST to answer questions. - - -/label ~"Container::Update" diff --git a/.gitlab/issue_templates/Bug.md b/.gitlab/issue_templates/Bug.md deleted file mode 100644 index 069eaf0..0000000 --- a/.gitlab/issue_templates/Bug.md +++ /dev/null @@ -1,41 +0,0 @@ -## Summary - -(Summarize the bug encountered concisely) - - -## Steps to reproduce - -(How one can reproduce the issue - this is very important) - - -## What is the current bug behavior? - -(What actually happens) - - -## What is the expected correct behavior? - -(What you should see instead) - - -## Relevant logs and/or screenshots - -(Paste any relevant logs - please use code blocks (```) to format console output, -logs, and code as it's very hard to read otherwise.) - - -## Possible fixes - -(If you can, link to the line of code that might be responsible for the problem) - - -## Defintion of Done -- [ ] Bug has been identified and corrected within the container - - - - - - - -/label ~Bug \ No newline at end of file diff --git a/.gitlab/issue_templates/Feature Request.md b/.gitlab/issue_templates/Feature Request.md deleted file mode 100644 index aad0671..0000000 --- a/.gitlab/issue_templates/Feature Request.md +++ /dev/null @@ -1,36 +0,0 @@ -## Feature description - -(Detailed description of the feature being requested) - - -## Use cases - - -(Detailed description of the use case for this feature) - - -## Benefits - -(How does this benefit others) - - -## Requirements - -(Any requirements for this feature to be enabled?) - - -## Links / references - -(List of links or references that support this feature) - - -## Definition of Done -- [ ] Feature has been implemented - - - - - - - -/label ~Feature \ No newline at end of file diff --git a/.gitlab/issue_templates/Leadership Question.md b/.gitlab/issue_templates/Leadership Question.md deleted file mode 100644 index b2cf9e5..0000000 --- a/.gitlab/issue_templates/Leadership Question.md +++ /dev/null @@ -1,12 +0,0 @@ -## Leadership question - -(Detailed description of the question you'd like to ask the leadership team) - - - - - - - -/label ~"Question::Leadership" ~"To Do" -/cc @ironbank-notifications/leadership \ No newline at end of file diff --git a/.gitlab/issue_templates/New Findings.md b/.gitlab/issue_templates/New Findings.md deleted file mode 100644 index 8fcdc03..0000000 --- a/.gitlab/issue_templates/New Findings.md +++ /dev/null @@ -1,30 +0,0 @@ -## Summary - -New findings discovered during continuous monitoring. - -## Tasks - -Contributor: -- [ ] Provide justifications for findings in the [VAT](https://vat.dso.mil) ([docs](https://repo1.dso.mil/dsop/dccscr/-/blob/master/pre-approval/vat.md)) -- [ ] Apply the ~"Approval" label to this issue and wait for feedback - -Iron Bank: -- [ ] Review findings and justifications -- [ ] Send approval request to Authorizing Official -- [ ] Close issue after approval from Authorizing Official - -> Note: If the above approval process is rejected for any reason, the `Approval` label will be removed and the issue will be sent back to `Open`. Any comments will be listed in this issue for you to address. Once they have been addressed, you **must** re-add the `Approval` label. - -## Questions? - -Contact the Iron Bank team by commenting on this issue with your questions or concerns. If you do not receive a response, add `/cc @ironbank-notifications/onboarding`. - -Additionally, Iron Bank hosts an [AMA](https://www.zoomgov.com/meeting/register/vJIsf-ytpz8qHSN_JW8Hl9Qf0AZZXSCSmfo) working session every Wednesday from 1630-1730EST to answer questions. - - - - - - - -/label ~"Container::New Findings" diff --git a/.gitlab/issue_templates/Onboarding Question.md b/.gitlab/issue_templates/Onboarding Question.md deleted file mode 100644 index 8dd13f1..0000000 --- a/.gitlab/issue_templates/Onboarding Question.md +++ /dev/null @@ -1,13 +0,0 @@ -## Onboarding question - -(Detailed description of the question you'd like to ask the onboarding team) - - - - - - - -/label ~"Question::Onboarding" ~"CSO::To Do" -/cc @ironbank-notifications/onboarding -/assign @ironbank-notifications/onboarding \ No newline at end of file diff --git a/.gitlab/issue_templates/Pipeline Failure.md b/.gitlab/issue_templates/Pipeline Failure.md deleted file mode 100644 index 36aa982..0000000 --- a/.gitlab/issue_templates/Pipeline Failure.md +++ /dev/null @@ -1,36 +0,0 @@ -## Summary - -(Summarize the pipeline issue encountered concisely) - - -## Link to failed pipeline - -(Link to the failed pipeline) - - -## What is the current bug behavior? - -(What actually happens) - - -## What is the expected correct behavior? - -(What you should see instead) - - -## Possible fixes - -(If you can, link to the line of code that might be responsible for the problem) - - -## Definition of Done -- [ ] Pipeline failure has been resolved - - - - - - - - -/label ~Pipeline \ No newline at end of file -- GitLab