Suggestions for test
Feature description
These are suggestions that improve the items in test directory for the development branch
nginx.conf - This is a more comprehensive set of rules specific to Drupal. https://www.nginx.com/resources/wiki/start/topics/recipes/drupal/
docker-compose.yml - This change proposes would enable easier development for Drupal by pointing the Drupal’s Root in the PHP container and the web root (of the Drupal) to nginx and certbot. The recommended web root is in web (which is different than the “Drupal root” that may contain additional vendor dependencies and config. https://github.com/drupal/recommended-project/blob/9.1.x/composer.json#L37
Use cases
When building/running this image locally, I ran into a couple of "gotchas". These alleviate those issues.
Benefits
By changing the docker-compose file, especially for working in a local environment, it is easier to work with the Drupal root above the web root as that is how the recommended composer file is set up.
The nginx conf changes are in case someone wants to "copy/paste" this config. It will protect certain files from being accessed and correctly route files to the PHP backend (for example the /private/ directory).
Requirements
Links / references
https://github.com/drupal/recommended-project/blob/9.1.x/composer.json is the recommended composer file for running Drupal; it shows other directories above the web root (so this is how the docker-compose file should map those items.
Definition of Done
Either take the suggestions and merge them in development, close this feature request, or a mix of the two
(note the files are attached)