From dfa1550d76119eb326a15d839d86edde3787d031 Mon Sep 17 00:00:00 2001 From: Joshua Eason Date: Thu, 17 Sep 2020 14:26:06 -0600 Subject: [PATCH 1/5] Adding issue templates --- .../issue_templates/Archive Application.md | 16 +++++++++ .gitlab/issue_templates/Bug.md | 34 +++++++++++++++++++ .gitlab/issue_templates/Feature Request.md | 28 +++++++++++++++ .gitlab/issue_templates/Update Application.md | 18 ++++++++++ 4 files changed, 96 insertions(+) create mode 100644 .gitlab/issue_templates/Archive Application.md create mode 100644 .gitlab/issue_templates/Bug.md create mode 100644 .gitlab/issue_templates/Feature Request.md create mode 100644 .gitlab/issue_templates/Update Application.md diff --git a/.gitlab/issue_templates/Archive Application.md b/.gitlab/issue_templates/Archive Application.md new file mode 100644 index 0000000..e845747 --- /dev/null +++ b/.gitlab/issue_templates/Archive Application.md @@ -0,0 +1,16 @@ +## Summary + +Requesting this application be archived due to one of the following reasons: +- [ ] Version is no longer supported by vendor +- [ ] Application is End-Of-Life +- [ ] License violation. +- [ ] Other. See below. + +## Detailed Description + +(Please provide a detailed description of why this application should be archived) + + + + +/label ~archive \ No newline at end of file diff --git a/.gitlab/issue_templates/Bug.md b/.gitlab/issue_templates/Bug.md new file mode 100644 index 0000000..7b5806e --- /dev/null +++ b/.gitlab/issue_templates/Bug.md @@ -0,0 +1,34 @@ +## Summary + +(Summarize the bug encountered concisely) + + +## Steps to reproduce + +(How one can reproduce the issue - this is very important) + + +## What is the current bug behavior? + +(What actually happens) + + +## What is the expected correct behavior? + +(What you should see instead) + + +## Relevant logs and/or screenshots + +(Paste any relevant logs - please use code blocks (```) to format console output, +logs, and code as it's very hard to read otherwise.) + + +## Possible fixes + +(If you can, link to the line of code that might be responsible for the problem) + + + + +/label ~bug \ No newline at end of file diff --git a/.gitlab/issue_templates/Feature Request.md b/.gitlab/issue_templates/Feature Request.md new file mode 100644 index 0000000..27316e2 --- /dev/null +++ b/.gitlab/issue_templates/Feature Request.md @@ -0,0 +1,28 @@ +## Feature description + +(Detailed description of the feature being requested) + + +## Use cases + + +(Detailed description of the use case for this feature) + + +## Benefits + +(How does this benefit others) + + +## Requirements + +(Any requirements for this feature to be enabled?) + + +## Links / references + +(List of links or references that support this feature) + + + +/label ~feature \ No newline at end of file diff --git a/.gitlab/issue_templates/Update Application.md b/.gitlab/issue_templates/Update Application.md new file mode 100644 index 0000000..60535a5 --- /dev/null +++ b/.gitlab/issue_templates/Update Application.md @@ -0,0 +1,18 @@ +# Summary + +Requesting application be updated to a newer version. + + + +# Version Information + +Current version: (State the current version of the application as you see it) + +Updated version: (State the version you would like the application updated to) + +Under support: (Is the updated version within the same major version of the application or is this a new major version?) + + + + +/label ~update \ No newline at end of file -- GitLab From b620da00fad4244c8b43dacc20a73e4c558ee0ff Mon Sep 17 00:00:00 2001 From: Joshua Eason Date: Tue, 6 Oct 2020 08:09:00 -0600 Subject: [PATCH 2/5] Updated templates --- .gitlab/CODEOWNERS | 7 +++++ .../issue_templates/Archive Application.md | 3 +- .gitlab/issue_templates/Bug.md | 3 +- .gitlab/issue_templates/Feature Request.md | 3 +- .../issue_templates/Leadership Question.md | 7 +++++ .../issue_templates/Onboarding Question.md | 7 +++++ .gitlab/issue_templates/Pipeline Failure.md | 29 +++++++++++++++++++ .gitlab/issue_templates/Update Application.md | 3 +- 8 files changed, 58 insertions(+), 4 deletions(-) create mode 100644 .gitlab/CODEOWNERS create mode 100644 .gitlab/issue_templates/Leadership Question.md create mode 100644 .gitlab/issue_templates/Onboarding Question.md create mode 100644 .gitlab/issue_templates/Pipeline Failure.md diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS new file mode 100644 index 0000000..11d201d --- /dev/null +++ b/.gitlab/CODEOWNERS @@ -0,0 +1,7 @@ +[Pipelines] +.gitlab-ci.yml @ironbank-notifications/cht +.gitlab-ci.yaml @ironbank-notifications/cht +Jenkinsfile + +[Gitlab Configuration Files] +.gitlab/* @ironbank-notifications/cht \ No newline at end of file diff --git a/.gitlab/issue_templates/Archive Application.md b/.gitlab/issue_templates/Archive Application.md index e845747..f6fb3df 100644 --- a/.gitlab/issue_templates/Archive Application.md +++ b/.gitlab/issue_templates/Archive Application.md @@ -13,4 +13,5 @@ Requesting this application be archived due to one of the following reasons: -/label ~archive \ No newline at end of file +/label ~archive +/cc @ironbank-notifications/archive \ No newline at end of file diff --git a/.gitlab/issue_templates/Bug.md b/.gitlab/issue_templates/Bug.md index 7b5806e..20fcdb7 100644 --- a/.gitlab/issue_templates/Bug.md +++ b/.gitlab/issue_templates/Bug.md @@ -31,4 +31,5 @@ logs, and code as it's very hard to read otherwise.) -/label ~bug \ No newline at end of file +/label ~bug +/cc @ironbank-notifications/bug \ No newline at end of file diff --git a/.gitlab/issue_templates/Feature Request.md b/.gitlab/issue_templates/Feature Request.md index 27316e2..b13cc8c 100644 --- a/.gitlab/issue_templates/Feature Request.md +++ b/.gitlab/issue_templates/Feature Request.md @@ -25,4 +25,5 @@ -/label ~feature \ No newline at end of file +/label ~feature +/cc @ironbank-notifications/feature \ No newline at end of file diff --git a/.gitlab/issue_templates/Leadership Question.md b/.gitlab/issue_templates/Leadership Question.md new file mode 100644 index 0000000..0d84df2 --- /dev/null +++ b/.gitlab/issue_templates/Leadership Question.md @@ -0,0 +1,7 @@ +## Leadership question + +(Detailed description of the question you'd like to ask the leadership team) + + +/label ~leadership +/cc @ironbank-notifications/leadership \ No newline at end of file diff --git a/.gitlab/issue_templates/Onboarding Question.md b/.gitlab/issue_templates/Onboarding Question.md new file mode 100644 index 0000000..025ae1d --- /dev/null +++ b/.gitlab/issue_templates/Onboarding Question.md @@ -0,0 +1,7 @@ +## Onboarding question + +(Detailed description of the question you'd like to ask the onboarding team) + + +/label ~onboarding +/cc @ironbank-notifications/onboarding \ No newline at end of file diff --git a/.gitlab/issue_templates/Pipeline Failure.md b/.gitlab/issue_templates/Pipeline Failure.md new file mode 100644 index 0000000..b9ce91b --- /dev/null +++ b/.gitlab/issue_templates/Pipeline Failure.md @@ -0,0 +1,29 @@ +## Summary + +(Summarize the pipeline issue encountered concisely) + + +## Link to failed pipeline + +(Link to the failed pipeline) + + +## What is the current bug behavior? + +(What actually happens) + + +## What is the expected correct behavior? + +(What you should see instead) + + +## Possible fixes + +(If you can, link to the line of code that might be responsible for the problem) + + + + +/label ~pipeline ~bug +/cc @ironbank-notifications/pipelines \ No newline at end of file diff --git a/.gitlab/issue_templates/Update Application.md b/.gitlab/issue_templates/Update Application.md index 60535a5..7a06f3c 100644 --- a/.gitlab/issue_templates/Update Application.md +++ b/.gitlab/issue_templates/Update Application.md @@ -15,4 +15,5 @@ Under support: (Is the updated version within the same major version of the appl -/label ~update \ No newline at end of file +/label ~update +/cc @ironbank-notifications/updates \ No newline at end of file -- GitLab From 608e8d3dab76cf8104ed9aebaf2e1e12c83aebb6 Mon Sep 17 00:00:00 2001 From: Joshua Eason Date: Tue, 6 Oct 2020 11:20:51 -0600 Subject: [PATCH 3/5] Removing Jenkinsfile protection --- .gitlab/CODEOWNERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 11d201d..64a2c68 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -1,7 +1,6 @@ [Pipelines] .gitlab-ci.yml @ironbank-notifications/cht .gitlab-ci.yaml @ironbank-notifications/cht -Jenkinsfile [Gitlab Configuration Files] -.gitlab/* @ironbank-notifications/cht \ No newline at end of file +.gitlab/* @ironbank-notifications/cht -- GitLab From 5b46f4a98896981f871f1576d5b686f83e2267eb Mon Sep 17 00:00:00 2001 From: Joshua Eason Date: Thu, 8 Oct 2020 18:08:34 -0600 Subject: [PATCH 4/5] Updating issue templates --- .gitlab/issue_templates/Access Request.md | 16 +++++++++ ...pplication.md => Application - Archive.md} | 6 +++- .../issue_templates/Application - Initial.md | 32 +++++++++++++++++ .../issue_templates/Application - Update.md | 35 +++++++++++++++++++ .gitlab/issue_templates/Bug.md | 2 ++ .gitlab/issue_templates/Feature Request.md | 3 ++ .../issue_templates/Leadership Question.md | 2 +- .gitlab/issue_templates/New Findings.md | 20 +++++++++++ .../issue_templates/Onboarding Question.md | 2 +- .gitlab/issue_templates/Pipeline Failure.md | 4 ++- .gitlab/issue_templates/Update Application.md | 19 ---------- 11 files changed, 118 insertions(+), 23 deletions(-) create mode 100644 .gitlab/issue_templates/Access Request.md rename .gitlab/issue_templates/{Archive Application.md => Application - Archive.md} (56%) create mode 100644 .gitlab/issue_templates/Application - Initial.md create mode 100644 .gitlab/issue_templates/Application - Update.md create mode 100644 .gitlab/issue_templates/New Findings.md delete mode 100644 .gitlab/issue_templates/Update Application.md diff --git a/.gitlab/issue_templates/Access Request.md b/.gitlab/issue_templates/Access Request.md new file mode 100644 index 0000000..77936b2 --- /dev/null +++ b/.gitlab/issue_templates/Access Request.md @@ -0,0 +1,16 @@ +## Summary + +The following individuals are requesting access to this project (one per line): +(List or tag all individuals here) + + +The access level should be: +- [ ] Developer access +- [ ] Remove access + + +## Definition of Done +- [ ] All accounts have been provided the necessary accesses + + +/label ~access ~"To Do" \ No newline at end of file diff --git a/.gitlab/issue_templates/Archive Application.md b/.gitlab/issue_templates/Application - Archive.md similarity index 56% rename from .gitlab/issue_templates/Archive Application.md rename to .gitlab/issue_templates/Application - Archive.md index f6fb3df..9e6d83f 100644 --- a/.gitlab/issue_templates/Archive Application.md +++ b/.gitlab/issue_templates/Application - Archive.md @@ -11,7 +11,11 @@ Requesting this application be archived due to one of the following reasons: (Please provide a detailed description of why this application should be archived) +## Definition of Done +- [ ] Application has been reviewed for archival +- [ ] Project is officially marked as stale +- [ ] Iron Bank frontend no longer lists application as available or approved -/label ~archive +/label ~container::archive /cc @ironbank-notifications/archive \ No newline at end of file diff --git a/.gitlab/issue_templates/Application - Initial.md b/.gitlab/issue_templates/Application - Initial.md new file mode 100644 index 0000000..6594a05 --- /dev/null +++ b/.gitlab/issue_templates/Application - Initial.md @@ -0,0 +1,32 @@ +## Summary + +Requesting application to be hardened. This is only for initial hardening of a container. + + +## Version Information + +Current version: (State the current version of the application as you see it) + +Under support: (Is the updated version within the same major version of the application or is this a new major version?) + + +## Definition of Done +Hardening: +- [ ] Container builds successfully +- [ ] Greylist file has been created (requires a member from container hardening) +- [ ] Branch has been merged into `development` + +Justifications: +- [ ] All findings have been justified per the above documentation +- [ ] Justifications have been provided to the container hardening team + +Approval Process (container hardening team processes): +- [ ] Peer review from Container Hardening Team +- [ ] Findings Approver has reviewed and approved all justifications +- [ ] Approval request has been sent to Authorizing Official +- [ ] Approval request has been processed by Authorizing Official + + + +/label ~"Container::Initial" +/cc @ironbank-notifications/cht \ No newline at end of file diff --git a/.gitlab/issue_templates/Application - Update.md b/.gitlab/issue_templates/Application - Update.md new file mode 100644 index 0000000..d88903c --- /dev/null +++ b/.gitlab/issue_templates/Application - Update.md @@ -0,0 +1,35 @@ +## Summary + +Requesting application be updated to a newer version. + + + +## Version Information + +Current version: (State the current version of the application as you see it) + +Updated version: (State the version you would like the application updated to) + +Under support: (Is the updated version within the same major version of the application or is this a new major version?) + + +## Definition of Done +Hardening: +- [ ] Container builds successfully +- [ ] Container version has been updated in greylist file +- [ ] Branch has been merged into `development` + +Justifications: +- [ ] All findings have been justified per the above documentation +- [ ] Justifications have been provided to the container hardening team + +Approval Process: +- [ ] Peer review from Container Hardening Team +- [ ] Findings Approver has reviewed and approved all justifications +- [ ] Approval request has been sent to Authorizing Official +- [ ] Approval request has been processed by Authorizing Official + + + +/label ~container::update +/cc @ironbank-notifications/updates \ No newline at end of file diff --git a/.gitlab/issue_templates/Bug.md b/.gitlab/issue_templates/Bug.md index 20fcdb7..398f199 100644 --- a/.gitlab/issue_templates/Bug.md +++ b/.gitlab/issue_templates/Bug.md @@ -29,6 +29,8 @@ logs, and code as it's very hard to read otherwise.) (If you can, link to the line of code that might be responsible for the problem) +## Defintion of Done +- [ ] Bug has been identified and corrected within the container /label ~bug diff --git a/.gitlab/issue_templates/Feature Request.md b/.gitlab/issue_templates/Feature Request.md index b13cc8c..421d1a4 100644 --- a/.gitlab/issue_templates/Feature Request.md +++ b/.gitlab/issue_templates/Feature Request.md @@ -24,6 +24,9 @@ (List of links or references that support this feature) +## Definition of Done +- [ ] Feature has been implemented + /label ~feature /cc @ironbank-notifications/feature \ No newline at end of file diff --git a/.gitlab/issue_templates/Leadership Question.md b/.gitlab/issue_templates/Leadership Question.md index 0d84df2..2d3b095 100644 --- a/.gitlab/issue_templates/Leadership Question.md +++ b/.gitlab/issue_templates/Leadership Question.md @@ -3,5 +3,5 @@ (Detailed description of the question you'd like to ask the leadership team) -/label ~leadership +/label ~question::leadership ~"To Do" /cc @ironbank-notifications/leadership \ No newline at end of file diff --git a/.gitlab/issue_templates/New Findings.md b/.gitlab/issue_templates/New Findings.md new file mode 100644 index 0000000..4efb1de --- /dev/null +++ b/.gitlab/issue_templates/New Findings.md @@ -0,0 +1,20 @@ +## Summary + +Container has new findings discovered during continuous monitoring. + + + +## Definition of Done +Justifications: +- [ ] All findings have been justified +- [ ] Justifications have been provided to the container hardening team + +Approval Process: +- [ ] Findings Approver has reviewed and approved all justifications +- [ ] Approval request has been sent to Authorizing Official +- [ ] Approval request has been processed by Authorizing Official + + + +/label ~"container::new findings" +/cc @ironbank-notifications/security \ No newline at end of file diff --git a/.gitlab/issue_templates/Onboarding Question.md b/.gitlab/issue_templates/Onboarding Question.md index 025ae1d..7c4a6d0 100644 --- a/.gitlab/issue_templates/Onboarding Question.md +++ b/.gitlab/issue_templates/Onboarding Question.md @@ -3,5 +3,5 @@ (Detailed description of the question you'd like to ask the onboarding team) -/label ~onboarding +/label ~question::onboarding /cc @ironbank-notifications/onboarding \ No newline at end of file diff --git a/.gitlab/issue_templates/Pipeline Failure.md b/.gitlab/issue_templates/Pipeline Failure.md index b9ce91b..28567df 100644 --- a/.gitlab/issue_templates/Pipeline Failure.md +++ b/.gitlab/issue_templates/Pipeline Failure.md @@ -23,7 +23,9 @@ (If you can, link to the line of code that might be responsible for the problem) +## Definition of Done +- [ ] Pipeline failure has been resolved -/label ~pipeline ~bug +/label ~pipeline /cc @ironbank-notifications/pipelines \ No newline at end of file diff --git a/.gitlab/issue_templates/Update Application.md b/.gitlab/issue_templates/Update Application.md deleted file mode 100644 index 7a06f3c..0000000 --- a/.gitlab/issue_templates/Update Application.md +++ /dev/null @@ -1,19 +0,0 @@ -# Summary - -Requesting application be updated to a newer version. - - - -# Version Information - -Current version: (State the current version of the application as you see it) - -Updated version: (State the version you would like the application updated to) - -Under support: (Is the updated version within the same major version of the application or is this a new major version?) - - - - -/label ~update -/cc @ironbank-notifications/updates \ No newline at end of file -- GitLab From a2e0d03f95a7cf045290d1c9308f806bf8d19159 Mon Sep 17 00:00:00 2001 From: Joshua Eason Date: Thu, 8 Oct 2020 18:11:39 -0600 Subject: [PATCH 5/5] Fixing labels --- .gitlab/issue_templates/Access Request.md | 2 +- .gitlab/issue_templates/Application - Archive.md | 2 +- .gitlab/issue_templates/Application - Update.md | 2 +- .gitlab/issue_templates/Bug.md | 2 +- .gitlab/issue_templates/Feature Request.md | 2 +- .gitlab/issue_templates/Leadership Question.md | 2 +- .gitlab/issue_templates/New Findings.md | 2 +- .gitlab/issue_templates/Onboarding Question.md | 2 +- .gitlab/issue_templates/Pipeline Failure.md | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitlab/issue_templates/Access Request.md b/.gitlab/issue_templates/Access Request.md index 77936b2..1a7b224 100644 --- a/.gitlab/issue_templates/Access Request.md +++ b/.gitlab/issue_templates/Access Request.md @@ -13,4 +13,4 @@ The access level should be: - [ ] All accounts have been provided the necessary accesses -/label ~access ~"To Do" \ No newline at end of file +/label ~"Access" ~"To Do" \ No newline at end of file diff --git a/.gitlab/issue_templates/Application - Archive.md b/.gitlab/issue_templates/Application - Archive.md index 9e6d83f..9f3b5fe 100644 --- a/.gitlab/issue_templates/Application - Archive.md +++ b/.gitlab/issue_templates/Application - Archive.md @@ -17,5 +17,5 @@ Requesting this application be archived due to one of the following reasons: - [ ] Iron Bank frontend no longer lists application as available or approved -/label ~container::archive +/label ~"Container::Archive" /cc @ironbank-notifications/archive \ No newline at end of file diff --git a/.gitlab/issue_templates/Application - Update.md b/.gitlab/issue_templates/Application - Update.md index d88903c..caebb3e 100644 --- a/.gitlab/issue_templates/Application - Update.md +++ b/.gitlab/issue_templates/Application - Update.md @@ -31,5 +31,5 @@ Approval Process: -/label ~container::update +/label ~"Container::Update" /cc @ironbank-notifications/updates \ No newline at end of file diff --git a/.gitlab/issue_templates/Bug.md b/.gitlab/issue_templates/Bug.md index 398f199..1427a0c 100644 --- a/.gitlab/issue_templates/Bug.md +++ b/.gitlab/issue_templates/Bug.md @@ -33,5 +33,5 @@ logs, and code as it's very hard to read otherwise.) - [ ] Bug has been identified and corrected within the container -/label ~bug +/label ~Bug /cc @ironbank-notifications/bug \ No newline at end of file diff --git a/.gitlab/issue_templates/Feature Request.md b/.gitlab/issue_templates/Feature Request.md index 421d1a4..a0e2f19 100644 --- a/.gitlab/issue_templates/Feature Request.md +++ b/.gitlab/issue_templates/Feature Request.md @@ -28,5 +28,5 @@ - [ ] Feature has been implemented -/label ~feature +/label ~Feature /cc @ironbank-notifications/feature \ No newline at end of file diff --git a/.gitlab/issue_templates/Leadership Question.md b/.gitlab/issue_templates/Leadership Question.md index 2d3b095..4674f82 100644 --- a/.gitlab/issue_templates/Leadership Question.md +++ b/.gitlab/issue_templates/Leadership Question.md @@ -3,5 +3,5 @@ (Detailed description of the question you'd like to ask the leadership team) -/label ~question::leadership ~"To Do" +/label ~"Question::Leadership" ~"To Do" /cc @ironbank-notifications/leadership \ No newline at end of file diff --git a/.gitlab/issue_templates/New Findings.md b/.gitlab/issue_templates/New Findings.md index 4efb1de..068d029 100644 --- a/.gitlab/issue_templates/New Findings.md +++ b/.gitlab/issue_templates/New Findings.md @@ -16,5 +16,5 @@ Approval Process: -/label ~"container::new findings" +/label ~"Container::New Findings" /cc @ironbank-notifications/security \ No newline at end of file diff --git a/.gitlab/issue_templates/Onboarding Question.md b/.gitlab/issue_templates/Onboarding Question.md index 7c4a6d0..77dea11 100644 --- a/.gitlab/issue_templates/Onboarding Question.md +++ b/.gitlab/issue_templates/Onboarding Question.md @@ -3,5 +3,5 @@ (Detailed description of the question you'd like to ask the onboarding team) -/label ~question::onboarding +/label ~"Question::Onboarding" ~"To Do" /cc @ironbank-notifications/onboarding \ No newline at end of file diff --git a/.gitlab/issue_templates/Pipeline Failure.md b/.gitlab/issue_templates/Pipeline Failure.md index 28567df..28b82a9 100644 --- a/.gitlab/issue_templates/Pipeline Failure.md +++ b/.gitlab/issue_templates/Pipeline Failure.md @@ -27,5 +27,5 @@ - [ ] Pipeline failure has been resolved -/label ~pipeline +/label ~Pipeline /cc @ironbank-notifications/pipelines \ No newline at end of file -- GitLab