Address Shellcheck findings
Current Behavior
Shellcheck findings in the IB pipeline. We cannot fail on shellcheck because the master branch would fail.
Live Example
https://repo1.dso.mil/ironbank-tools/ironbank-pipeline/-/jobs/2994424
Expected Behavior
All shellcheck findings should be mitigated or added to new issue to discuss ignoring if they cannot be mitigated.
Possible Solution
- Examine the shellcheck findings for the development branch of the IB pipeline.
- Research and mitigate the shellcheck findings.
- For each stage that is modified, compare output artifacts and gitlab logs between the development branch and the new branch.
- Verify the pipeline behavior is not affected by the shellcheck mitigations.
Edited by stephen.swanson