Add additional pylint rules for subprocess guidance from the contributor's guide
Background
In #829 (closed), we created a pylint checker to validate that subprocess_error_handler
decorates any function that uses subprocess. We need to create other pylint checkers for other subprocess rules we enforce in the contributor's guide (that aren't already coverered like check=True
).
Acceptance Criteria
-
Subprocess rules are created for the following. -
Error - subprocess is using shell=True -
Error - don't provide cmd as a list of strings -
Error - using subprocess.Popen
without usingwith
-
Definition of Done
-
Additional checks for subprocess issues are added -
Changes to pylint have been tested locally -
Considerations are made for -
running locally -
vscode -
our pylint ci job
-
Edited by Kenneth Maguire