GitLab

A whole mess of rhsm role updates

Modify role behavior to prevent resubscription of a system when
`rhsm_unregister` is `true` but `rhsm_username` or `rhsm_activationkey`
is still set.

On a system that needs to be registered, subscription-manager should
already be installed. If subscription-manager is not installed (this
should never happen), it would then need to be installed, which would
require a registered system, which would have required subscription-
manager to be installed.

tl;dr you can't install subscription-manager without subscription-
manager, so...we can safely assume it's installed.

Rename rhsm_repository_release to rhsm_release

This module was renamed in ansible prior to the 2.8 release. This
updates the role vendoring to adapt to the name change.

Various CI updates and improvements

This is breaking ansible-lint in travis. Removing this is the first step
in the process for deprecating and removing support for outputs from
this role.

In documenting ways to best test roles that require subscriptions, and
in light of changes either recently applied to or soon coming to the
molecule_openstack_ci role, I made a few changes to test the docs that
I'm writing.

This commit attempts to clean up the rhsm role to more properly work
with the new envvar-based method for getting at the subscription
information, removes the unused docker scenario, and fixes up the
openstack provisioning playbooks to better match how the
molecule_openstack_ci does things.

Add a daily cron trigger

There are a ton of different triggers that can give us cron-like
behavior. It's my hope that using this in conjunction with the github
branch folders mean we'll continue to get the current and desired
behavior from those jobs, and just get the daily cron trigger added on
top.

If this doesn't work, then we may end up having to effectively redeclare
the github branches config in every job. Hopefully this works. :)

Due to changes in how RHSM vars are loaded, getting at the list of
expected pool IDs from outside of ansible is a little less reliable.
This test is modified just to check that the subscribed pool IDs are
correctly added to the output yaml.

I also added some entries to the gitignore to ignore test-generated
artifacts.

Due to the way the github org folder plugin names workspaces, autodetection of the role name from the workspace dir does not work. So, for this and all roles using an upstream Jenkinsfile, `molecule_role_name` appears to be required.

Move test scenarios upstream

This does a few things:
- With oasis-pipeline on github, all the tests can be on github now,
too. The only thing I see that needed to be redacted is the subscription
information, which now comes in via jankies env vars. The majority of
this change is the addition of a group_vars file to load the
subscription information from the env, and then updating the scenarios
to use those group_vars.
- The "downstream_openstack" scenario has entirely replaced the
"openstack" scenario previously in this repo.
- The Jenkinsfile itself now lives in this repo

If the rhsm group_vars approach deemed is good, I'll be documenting
that so it can easily be adapted to other roles that need subscriptions
for testing.

Use vendored rhsm_repository_release module

closes #10

Support ansible 2.4 with vendored library

This is effectively a proof of concept for a way to backport a module
from newer versions of ansible to work with a version of ansible that
did not have that module. In this case, rhsm_repository does not exist
in ansible 2.4. If (and only if) the installed version of ansible is
less than 2.5, this role will attempt to use the vendored version of the
task. Otherwise (ansible 2.5+), it will use the ansible builtin version
of the task.

Fix typos in the README.md

Missing tick before yaml caused the closing triple tick to invert the
status of escaped codeblocks throughout the rest of the file

The _ characters, therefore, were not registring as indicating an
underline

Correct LICENSE

Switched project to GPLv3 with the permission of existing contributors.

ansible 2.6 does not work with docker-py

Using docker library instead. They are the same library, but the pypi
name switched from "docker-py" to "docker" in 2.0:

https://docker-py.readthedocs.io/en/stable/change-log.html#breaking-changes

Ansible docs still refer to installing docker-py, so that's probably a
good docs fix opportunity?

Add support for release handling

Specifically, this adds support for the `--set` and `--unset` flags to
the `subscription-manager release` subcommand.

Register outputs from role

Add "pool" option and update gitignore

closes #1

privilege escalation is (as far as I know) always done when working with
subscription-manager, so now this role does it for you

(takes a deep breath)
Since these scenarios are wrapped with molecule, and molecule won't
pass the scenario if the role tasks don't work, I think it's reasonable
to consider molecule's ansible run as part of the testing stack, making
this test redundant.

test_subscription never actually tests anything related to subscriptions