add conditional for https redirects and use hosts instead of wildcard
Closes #39 (closed)
Closes #49 (closed)
These changes add in logic to use the servers.hosts entries in the auto-generated http->https redirect blocks instead of the global-matching "*"
In addition, the auto-generated redirect blocks can be enabled or disabled by redirectHttpToHttps.enabled value. If redirectHttpToHttps is not defined, the default is to generate the block.
The values file:
The generated Gateway definition:
Merge request reports
Activity
changed milestone to %1.19.0
added istio kindbug priority5 statusdoing teamXForce labels
added statusreview label and removed statusdoing label
- Resolved by Michael Martin
@michaelmartin testing this MR, I installed istio-controlplane from BB master, then upgraded to this branch, enabled the passthrough IGW+gateway and added
gateways.passthrough.redirectHttpToHttps.enabled: false
but the YAML for the installed gateway is still:spec: selector: app: passthrough-ingressgateway servers: - hosts: - keycloak.bigbang.dev port: name: http number: 8080 protocol: HTTP tls: httpsRedirect: true - hosts: - keycloak.bigbang.dev port: name: https number: 8443 protocol: HTTPS tls: credentialName: passthrough-cert mode: PASSTHROUGH
removed statusreview label
added statusdoing label
added statusreview label and removed statusdoing label
added 1 commit
- cecae59a - rename redirectHttpToHttps to autoHttpRedirect for clarity
- Resolved by Michael McLeroy
- Resolved by Michael Martin