No default pull secrets for deleteWebhookConfigurations and labelNamespace

There is no default image pull secrets for deleteWebhookConfigurations and labelNamespace. This seems like an oversight. It is problematic when you are trying to move to a private registry or use the robot creds for registry1. They should default to the private-registry as main gatekeeper image.

https://repo1.dso.mil/platform-one/big-bang/apps/core/policy/-/blob/main/chart/values.yaml#L46-53

https://repo1.dso.mil/platform-one/big-bang/apps/core/policy/-/blob/main/chart/values.yaml#L29-36

If deploying via Big Bang these are defaulted to private-registry - https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/master/chart/templates/gatekeeper/values.yaml#L10-22

Deploying via Big Bang is our primary intended use. We certainly could add that as a default in the spots you identified as well, which would help when someone is deploying this as a "standalone" chart.

Actually I was mistaken on this - these two cover the label namespace and an older upgrade crds job, but not the webhook value you identified. We can update and make sure that pull secrets are set for everything properly.

changed milestone to %1.40.0

changed iteration to Big Bang Iterations Jul 26, 2022 - Aug 8, 2022

set weight to 2

added gatekeeper teamcore/security labels

@micah.nagel Thanks for looking. I definitely ran into the delete web hook issue when deploying with BigBang.

Perhaps, the default value pull image secrets could be used if these are empty and could be overridden if needed.

set weight to 1

changed milestone to %1.41.0

changed iteration to Big Bang Iterations Aug 9, 2022 - Aug 22, 2022

added community-contribution label

assigned to @davevigil

added statusdoing label

added statusreview label and removed statusdoing label

closed with merge request big-bang/bigbang!1978 (merged)

removed statusreview label