complete Gitlab istio injection for migration job
migration job
k8s jobs that run and then complete have difficulty with istio injection because the istio sidecar container stays alive and prevents the pod from finishing. Fix the migration job script to kill the istio sidecar at the end of the script.
Reference original istio injection MR
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/merge_requests/91
Instructions
TBD
Here are some examples how to fix:
https://repo1.dso.mil/platform-one/big-bang/apps/core/monitoring/-/blob/main/chart/templates/prometheus-operator/admission-webhooks/job-patch/job-createSecret.yaml#L48-L57
https://repo1.dso.mil/platform-one/big-bang/apps/core/elasticsearch-kibana/-/merge_requests/69/diffs#5b7174495e64650927423aa9b1b61a6c8bea073c_133_132
BigBang changes
When the MR for BigBang is cretaed the lines in the Gitlab template values to disable istio injection need to be disabled.
https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/master/chart/templates/gitlab/values.yaml#L79-83
{{- if .Values.istio.enabled }}
migrations:
annotations:
sidecar.istio.io/inject: "false"
{{- end }}