From 0a2e061539c9ea62bfa68dfac4fe52e45324032a Mon Sep 17 00:00:00 2001
From: Sam <sam@braingu.com>
Date: Fri, 16 Apr 2021 12:36:49 -0400
Subject: [PATCH] fix: made imagePullSecrets funtional

---
 chart/templates/deployment.yaml        |  4 ++--
 chart/templates/image-pull-secret.yaml | 10 ----------
 chart/values.yaml                      |  3 +--
 3 files changed, 3 insertions(+), 14 deletions(-)
 delete mode 100644 chart/templates/image-pull-secret.yaml

diff --git a/chart/templates/deployment.yaml b/chart/templates/deployment.yaml
index f873876..2f04be1 100644
--- a/chart/templates/deployment.yaml
+++ b/chart/templates/deployment.yaml
@@ -48,9 +48,9 @@ spec:
       hostAliases:
 {{ toYaml .Values.nexus.hostAliases | indent 8 }}
       {{- end }}
-      {{- if .Values.nexus.imagePullSecret }}
+      {{- with .Values.nexus.imagePullSecrets }}
       imagePullSecrets:
-        {{- toYaml . | nindent 8 }}
+        {{- toYaml . | nindent 8}}
       {{- end }}
       {{- if .Values.deployment.terminationGracePeriodSeconds }}
       terminationGracePeriodSeconds: {{ .Values.deployment.terminationGracePeriodSeconds }}
diff --git a/chart/templates/image-pull-secret.yaml b/chart/templates/image-pull-secret.yaml
deleted file mode 100644
index d70c3db..0000000
--- a/chart/templates/image-pull-secret.yaml
+++ /dev/null
@@ -1,10 +0,0 @@
-{{- if .Values.nexus.imagePullSecret -}}
-apiVersion: v1
-kind: Secret
-metadata:
-  name: {{ template "nexus.name" . }}
-data:
-  .dockerconfigjson: {{ .Values.nexus.imagePullSecret }}
-
-type: kubernetes.io/dockerconfigjson
-{{- end }}
\ No newline at end of file
diff --git a/chart/values.yaml b/chart/values.yaml
index b9926bd..54aac65 100644
--- a/chart/values.yaml
+++ b/chart/values.yaml
@@ -121,9 +121,8 @@ nexus:
   #   hostnames:
   #   - "example.com"
   #   - "www.example.com"
+  imagePullSecrets: []
 
-
-imagePullSecrets: []
 nameOverride: ""
 fullnameOverride: ""
 
-- 
GitLab