Jaeger HelmRelease broken when istio isn't enabled and in STRICT mode

Bug

Description

The code introduced in this commit doesn't leave a conditional alternative for the .Values.monitoring.serviceMonitor dictionary when Istio is not enabled and in STRICT mode for Jaeger. When the value does not have a dictionary to query, the ServiceMonitor template is unable to properly query for its scheme property.

BigBang Version

1.43.0

changed the description

assigned to @micah.nagel

mentioned in merge request !2098 (merged)

Should be fixed in the related MR.

This error shows up as an event similar to this:

Helm install failed: template: jaeger-operator/templates/bigbang/servicemonitor.yaml:12:20: executing "jaeger-operator/templates/bigbang/servicemonitor.yaml" at <.Values.monitoring.serviceMonitor.scheme>: nil pointer evaluating interface {}.scheme

To know if you affected by this issue before updating to 1.43.0, check your values overrides for one of the below:

istio:
  enabled: false

OR

jaeger:
  values:
    istio:
      mtls:
        mode: PERMISSIVE

A confirmed workaround is adding the below value:

jaeger:
  values:
    monitoring:
      serviceMonitor: {}

This is required to install Jaeger in 1.43.0 if Monitoring is enabled and either Istio is disabled or Jaeger mTLS is set to PERMISSIVE. As a reminder STRICT mTLS and Istio are best practices when using/consuming Big Bang.

closed with merge request !2098 (merged)

mentioned in commit d54a5682