Improve conditionals around Authservice/HAProxy
Currently the conditionals around Authservice/HAProxy only check for ${package}.sso.enabled
. They should really check for both ${package}.enabled
and ${package}.sso.enabled
.
See:
- https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/master/chart/templates/authservice/values.yaml#L55
- https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/master/chart/templates/authservice/values.yaml#L73
- https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/master/chart/templates/authservice/authservice-helmrelease.yaml#L2
- https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/master/chart/templates/haproxy/haproxy-authservice.yaml#L2
There may be other spots where this is a problem, this list is not necessarily comprehensive. For testing you can enable sso for a package but disable the package, i.e.:
monitoring:
enabled: false
sso:
enabled: true
jaeger:
enabled: false
sso:
enabled: true
AC:
-
BB templates updated to be conditional on both package enabled and package sso enabled
Edited by Micah Nagel