UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

Resolve "Transition all BB values to Secret objects parsed by `HelmRelease`"

Summary

  • Removes all inline HelmRelease values and replaces with {{ .Release.Name }}-<package>-values secret loaded via valuesFrom
    • These values are loaded before the values passthroughs so they get overridden by any customer defined values
    • the secret creation is handled by a named template values-secret
  • refactors all customer overlay values into the same secret with bb defaults but using a different overlays key
  • introduces common values that are set in the values-secret named template that all charts can use (currently empty)
  • Refactors haproxy-sso helmrelease into it's own file (instead of with the authservice namespace.yaml)
  • ensure istiooperator components are tied to .Values.istiooperator.enabled (instead of .Values.istio.enabled)

Closes #223 (closed)

Edited by joshwolf

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by joshwolf

      Only comment I have is that this is a somewhat big change that we need to make sure is communicated well especially for MRs that are in progress right now (even if it's basically just moving things between files, it'll mess with any MRs that modify the helmrelease for values stuff and could definitely cause confusion).

  • Now that !316 (merged) is merged you can update the developer docs as part of this!

  • Micah Nagel
  • joshwolf added 9 commits

    added 9 commits

    Compare with previous version

  • joshwolf added 1 commit

    added 1 commit

    • fb3002a5 - move leftover passthrough values to valuesFrom secrets

    Compare with previous version

  • joshwolf resolved all threads

    resolved all threads

  • Micah Nagel approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading