Merge branch 'BULL-1175' into 'master'

Bull 1175

See merge request !133

src/InitialLoadingApp.vue

@@ -65,6 +65,7 @@
               color="primary"
               href="https://jira.il2.dso.mil/servicedesk/customer/portal/1/create/137"
               target="_blank"
+              rel="noopener noreferer"
             >
               send ticket
             </v-btn>

src/components/APIErrorCard.vue

@@ -20,6 +20,7 @@
       <v-btn
         href="https://jira.il2.dso.mil/servicedesk/customer/portal/1/create/137"
         target="_blank"
+        rel="noopener noreferer"
         id="help_desk"
         class="primary mb-5"
         >Submit Ticket
@@ -40,6 +41,7 @@
           <v-btn
             href="https://jira.il2.dso.mil/servicedesk/customer/portal/1/create/137"
             target="_blank"
+            rel="noopener noreferer"
             id="help_desk"
             class="primary"
             >Submit Ticket

src/components/CurriculumSchedule.vue

@@ -35,6 +35,7 @@
                   color="secondary"
                   @click="getCertificate(item.course)"
                   target="_blank"
+                  rel="noopener noreferer"
                   v-bind="attrs"
                   v-on="on"
                 >
@@ -53,6 +54,7 @@
               color="secondary"
               href="https://www.galvanize.com/"
               target="_blank"
+              rel="noopener noreferer"
               class="no-link"
             >
               Go to Learn

src/components/ExternalLink.vue

 <template>
-  <a text class="link" :href="href" :class="{ inline }" target="_blank">
+  <a
+    text
+    class="link"
+    :href="href"
+    :class="{ inline }"
+    target="_blank"
+    rel="noopener noreferer"
+  >
     <div class="d-flex flex-nowrap">
       <slot></slot>
       <v-icon class="mt-n1 ml-1" aria-hidden="true">mdi-launch</v-icon>

src/components/HelpDeskSummary.vue

@@ -12,6 +12,7 @@
           color="primary"
           href="https://jira.il2.dso.mil/servicedesk/customer/portal/1"
           target="_blank"
+          rel="noopener noreferer"
           class="mx-auto no-link"
         >
           Submit Ticket
@@ -24,7 +25,11 @@
         Can't find a support form that meets your needs?
         <br />
         Email us at
-        <a href="mailto:help@dso.mil" target="_blank" class="email"
+        <a
+          href="mailto:help@dso.mil"
+          class="email"
+          target="_blank"
+          rel="noopener noreferer"
           >help@dso.mil</a
         >
       </div>
@@ -34,6 +39,7 @@
           color="tertiary"
           href="mailto:help@dso.mil"
           target="_blank"
+          rel="noopener noreferer"
           class="mx-auto"
         >
           Email

src/components/LaunchboardSettings.vue

@@ -18,6 +18,7 @@
                 v-on="on"
                 href="https://login.dso.mil/auth/realms/baby-yoda/account/"
                 target="_blank"
+                rel="noopener noreferer"
               >
                 <v-icon>mdi-pencil</v-icon>
               </v-btn>
@@ -83,7 +84,8 @@ export default {
   mounted() {
     this.user = this.$store.state.user.user;
     this.darkMode = this.$store.state.userPreferences.userPreference.darkMode;
-    this.welcomeMenu = this.$store.state.userPreferences.userPreference.welcomeMessage;
+    this.welcomeMenu =
+      this.$store.state.userPreferences.userPreference.welcomeMessage;
     this.changeLoadingColor();
   },
   methods: {

src/components/ProjectsSummary.vue

@@ -71,6 +71,7 @@
                     v-if="project.links.repo"
                     :href="project.links.repo"
                     target="_blank"
+                    rel="noopener noreferer"
                   >
                     <v-list-item-icon>
                       <v-icon small class="ml-1">$vuetify.icons.gitlab</v-icon>
@@ -83,6 +84,7 @@
                     v-if="project.links.latestPipeline"
                     :href="project.links.latestPipeline"
                     target="_blank"
+                    rel="noopener noreferer"
                   >
                     <v-list-item-icon>
                       <GitLabIcon class="icon small ml-1" icon="rocket" />
@@ -95,6 +97,7 @@
                     v-if="project.links.jira"
                     :href="project.links.jira"
                     target="_blank"
+                    rel="noopener noreferer"
                   >
                     <v-list-item-icon>
                       <v-icon small class="ml-1">$vuetify.icons.jira</v-icon>
@@ -107,6 +110,7 @@
                     v-if="project.links.confluence"
                     :href="project.links.confluence"
                     target="_blank"
+                    rel="noopener noreferer"
                   >
                     <v-list-item-icon>
                       <v-icon small class="ml-1">
@@ -127,6 +131,7 @@
                       icon
                       :href="project.links.repo"
                       target="_blank"
+                      rel="noopener noreferer"
                       v-bind="attrs"
                       v-on="on"
                       @click.native.stop
@@ -144,6 +149,7 @@
                       icon
                       :href="project.links.latestPipeline"
                       target="_blank"
+                      rel="noopener noreferer"
                       v-bind="attrs"
                       v-on="on"
                       @click.native.stop
@@ -161,6 +167,7 @@
                       icon
                       :href="project.links.jira"
                       target="_blank"
+                      rel="noopener noreferer"
                       v-bind="attrs"
                       v-on="on"
                       @click.native.stop
@@ -178,6 +185,7 @@
                       icon
                       :href="project.links.confluence"
                       target="_blank"
+                      rel="noopener noreferer"
                       v-bind="attrs"
                       v-on="on"
                       @click.native.stop
@@ -201,6 +209,7 @@
                 :key="jIndex"
                 :href="job.link"
                 target="_blank"
+                rel="noopener noreferer"
               >
                 <v-list-item-icon>
                   <GitLabIcon class="status-icon" :status="job.status" />

src/components/ToolsSummary.vue

@@ -20,6 +20,7 @@
           color="secondary"
           :href="tool.link.href"
           target="_blank"
+          rel="noopener noreferer"
           class="mx-auto no-link"
         >
           {{ tool.link.text }}

src/components/Training/TrainingAttendance.vue

@@ -126,6 +126,7 @@
           <a
             :href="'mailto:' + item.user.email"
             target="_blank"
+            rel="noopener noreferer"
             class="d-flex flex-wrap mx-0 pl-9 ml-9 mb-4 text-left"
             v-if="item.user.email"
           >

src/views/Resources.vue

@@ -17,6 +17,7 @@
                 color="secondary"
                 href="https://confluence.il2.dso.mil/display/GROGU/7.3+A+Stylized+Exportable+PDF"
                 target="_blank"
+                rel="noopener noreferer"
                 class="mx-auto no-link my-4"
                 >DOWNLOAD GUIDE
               </v-btn>

src/views/Team.vue

@@ -71,6 +71,7 @@
           min-width="200"
           href="https://jira.il2.dso.mil/servicedesk/customer/portal/1"
           target="_blank"
+          rel="noopener noreferer"
         >
           Customer Success Team
         </v-btn>
@@ -90,6 +91,7 @@
             color="tertiary"
             href="https://jira.il2.dso.mil/servicedesk/customer/portal/1"
             target="_blank"
+            rel="noopener noreferer"
             class="mx-auto no-link"
           >
             Submit Ticket
@@ -200,7 +202,7 @@
           <template v-slot:[`item.username`]="{ item }">
             <a
               target="_blank"
-              rel="noopener"
+              rel="noopener noreferer"
               :href="`https://chat.il2.dso.mil/platform-one/messages/@${item.username}`"
             >
               @{{ item.username }}
@@ -229,6 +231,7 @@
                 class="mr-3"
                 color="accent"
                 target="_blank"
+                rel="noopener noreferer"
                 @click="emailSelected"
                 :disabled="selectedMembers.length === 0"
               >

src/views/super-admin/Teams.vue

@@ -87,7 +87,7 @@
               <a
                 :href="`mailto:${lead.email}`"
                 target="_blank"
-                rel="noopener"
+                rel="noopener noreferer"
                 class="lead-name"
                 >{{ lead.name }}</a
               >
@@ -102,7 +102,7 @@
               <a
                 :href="`mailto:${lead.email}`"
                 target="_blank"
-                rel="noopener"
+                rel="noopener noreferer"
                 class="lead-name"
                 >{{ lead.email }}</a
               >

src/views/super-admin/Training.vue

@@ -172,7 +172,7 @@
                   v-if="!onMobile"
                   :href="`mailto:${instructor.email}`"
                   target="_blank"
-                  rel="noopener"
+                  rel="noopener noreferer"
                   class="white-space-nowrap"
                 >
                   {{ instructor.name }}</a
@@ -193,6 +193,7 @@
                     v-on="on"
                     :href="`mailto:${item.instructors[0].email},${item.instructors[1].email}`"
                     target="_blank"
+                    rel="noopener noreferer"
                   >
                     <v-icon>mdi-email</v-icon>
                   </v-btn>
@@ -235,7 +236,7 @@
                 <a
                   :href="`mailto:${instructor.email}`"
                   target="_blank"
-                  rel="noopener"
+                  rel="noopener noreferer"
                   class="white-space-nowrap"
                 >
                   {{ instructor.name }}
@@ -256,6 +257,7 @@
                     v-on="on"
                     :href="`mailto:${item.instructors[0].email},${item.instructors[1].email}`"
                     target="_blank"
+                    rel="noopener noreferer"
                   >
                     <v-icon>mdi-email</v-icon>
                   </v-btn>

tests/unit/main.spec.js

@@ -12,7 +12,7 @@ const fakeWait = (ms, val) => {
 describe("main", () => {
   const mockUser = { name: "mockUser", roles: [] };
   const mockUserPreference = {
-    keycloakId: "12345678901234567890",
+    keycloakId: "mock-keycloak-id",
     darkMode: true,
   };