Merge branch 'LB-201' into 'master'

LB-201 test tweaks

See merge request platform-one/products/bullhorn/launchboard-fe!112

tests/unit/components/Training/TrainingAttendance.spec.js

@@ -548,10 +548,7 @@ describe("TrainingAttendance", () => {
     wrapper.vm.fetchDebounced = jest.fn();
 
     // trigger the watch for wrapper.vm.options
-    const mockOptions = 2;
-    wrapper.vm.reload = mockOptions;
-    await wrapper.vm.$nextTick();
-
+    await wrapper.setProps({ reload: 1 });
     expect(wrapper.vm.fetchDebounced).toHaveBeenCalledTimes(1);
   });
 

tests/unit/views/TrainingDetails.spec.js

@@ -17,6 +17,7 @@ describe("TrainingDetails", () => {
       trainingId: 42,
     },
   };
+  const mockCourse = { instructors: [] };
   const propsData = {
     trainingCourse: {
       id: 1,
@@ -29,6 +30,10 @@ describe("TrainingDetails", () => {
     jest.resetAllMocks();
   });
   it("should fetch debounced", async () => {
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
+    TrainingService.getCourseRegistrationsById = jest
+      .fn()
+      .mockResolvedValue({});
     TrainingDetails.fetchData = jest.fn();
     const wrapper = shallowMount(TrainingDetails, {
       mocks: {
@@ -51,10 +56,12 @@ describe("TrainingDetails", () => {
       vuetify,
     });
     expect(wrapper.vm.fetchingData).toBe(false);
+    await flushPromises();
     wrapper.vm.fetchDebounced();
     expect(wrapper.vm.fetchingData).toBe(true);
   });
   it("should fetchStudent data", async () => {
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     TrainingService.getCourseRegistrationsById = jest.fn().mockResolvedValue({
       meta: { total: 2 },
       registrations: [
@@ -68,7 +75,6 @@ describe("TrainingDetails", () => {
         {},
       ],
     });
-    TrainingDetails.courseDates = jest.fn().mockReturnValue([]);
     const wrapper = shallowMount(TrainingDetails, {
       mocks: {
         $route,
@@ -93,13 +99,13 @@ describe("TrainingDetails", () => {
     });
     await wrapper.vm.fetchStudentData();
     await flushPromises();
-    expect(TrainingService.getCourseRegistrationsById).toBeCalledTimes(1);
+    expect(TrainingService.getCourseRegistrationsById).toBeCalledTimes(2);
   });
   it("should fetchStudent data with an empty string", async () => {
     TrainingService.getCourseRegistrationsById = jest
       .fn()
       .mockResolvedValue({});
-    TrainingDetails.courseDates = jest.fn().mockReturnValue([]);
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     const wrapper = shallowMount(TrainingDetails, {
       mocks: {
         $route,
@@ -124,14 +130,14 @@ describe("TrainingDetails", () => {
     });
     await wrapper.vm.fetchStudentData();
     await flushPromises();
-    expect(TrainingService.getCourseRegistrationsById).toBeCalledTimes(1);
+    expect(TrainingService.getCourseRegistrationsById).toBeCalledTimes(2);
     expect(wrapper.vm.listItems).toStrictEqual([]);
   });
   it("should throw error in fetchStudent", async () => {
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     TrainingService.getCourseRegistrationsById = jest
       .fn()
       .mockRejectedValue("mock error");
-    TrainingDetails.courseDates = jest.fn().mockReturnValue([]);
     const wrapper = shallowMount(TrainingDetails, {
       mocks: {
         $route,
@@ -154,6 +160,7 @@ describe("TrainingDetails", () => {
       localVue,
       vuetify,
     });
+
     await wrapper.vm.fetchStudentData();
     await flushPromises();
     expect(wrapper.vm.$store.commit).toHaveBeenCalledWith(
@@ -166,6 +173,7 @@ describe("TrainingDetails", () => {
     );
   });
   it("should add student", async () => {
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     TrainingService.getCourseRegistrationsById = jest
       .fn()
       .mockResolvedValue({ registrations: [] });
@@ -196,6 +204,8 @@ describe("TrainingDetails", () => {
     expect(TrainingService.addStudents).toHaveBeenCalledTimes(1);
   });
   it("addStudent should catch error", async () => {
+    console.error = jest.fn(); // mock console.error when expecting error messages
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     TrainingService.addStudents = jest.fn().mockRejectedValue("error");
     const wrapper = shallowMount(TrainingDetails, {
       mocks: {
@@ -218,6 +228,7 @@ describe("TrainingDetails", () => {
     );
   });
   it("should cancel add student", async () => {
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     TrainingService.getCourseRegistrationsById = jest
       .fn()
       .mockResolvedValue({ registrations: [] });
@@ -248,7 +259,7 @@ describe("TrainingDetails", () => {
   });
 
   it("should not show error by default", () => {
-    TrainingService.getCourse = jest.fn().mockResolvedValue({});
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     // render the component
     const wrapper = shallowMount(TrainingDetails, {
       mocks: {
@@ -273,7 +284,7 @@ describe("TrainingDetails", () => {
   });
 
   it("should set training course snapshot and isEditingCourse on btnPushEditPoc", () => {
-    TrainingService.getCourse = jest.fn().mockResolvedValue({});
+    TrainingService.getCourse = jest.fn().mockResolvedValue(mockCourse);
     // render the component
     const wrapper = shallowMount(TrainingDetails, {
       mocks: {