more unit tests and refactoring

src/components/AddClass.vue → src/components/AddCourse.vue

@@ -158,7 +158,7 @@
           :disabled="!valid"
           color="primary"
           :loading="addBusy"
-          @click="addClass()"
+          @click="addCourse()"
         >
           Add Class
         </v-btn>
@@ -197,7 +197,7 @@ export default {
       this.$emit("cancel");
       this.init();
     },
-    addClass() {
+    addCourse() {
       this.$emit("add", this.toAdd);
       this.init();
     },

src/components/UserSelect.vue

@@ -148,7 +148,6 @@ export default {
     },
     async query(val) {
       try {
-        console.log("val:", val);
         const newItems = await UserService.search({ q: val });
         if (this.model) {
           if (Array.isArray(this.model)) {

src/views/TrainingDetails.vue

@@ -363,11 +363,9 @@ export default {
   }),
   computed: {
     getSelectedPocs() {
-      console.log(this.selectedPocs);
       return this.selectedPocs;
     },
     getSelectedStudents() {
-      console.log(this.selectedStudents);
       return this.selectedStudents;
     },
   },
@@ -376,12 +374,10 @@ export default {
     this.trainingCourse = await TrainingService.getCourse(
       this.$route.params.trainingId
     );
-    console.log(this.trainingCourse);
     this.loading = false;
   },
   methods: {
     removeSelectedStudent() {
-      console.log(this.getSelectedStudents);
       const removeStudentIds = this.getSelectedStudents.map(
         (student) => student.id
       );

src/views/super-admin/Training.vue

@@ -109,10 +109,10 @@
               </v-row>
             </v-container>
 
-            <AddClass
+            <AddCourse
               v-if="state.isAdding"
               @cancel="state.isAdding = false"
-              @add="addClass"
+              @add="addCourse"
               :add-busy="state.isAddingBusy"
             />
           </template>
@@ -269,7 +269,7 @@
 <script>
 import Vue from "vue";
 import TrainingService from "@/api/services/training";
-import AddClass from "@/components/AddClass";
+import AddCourse from "@/components/AddCourse";
 import { defaultSnackbarTimeout, debounceTimeout } from "@/config/config";
 import { trainingTypes } from "@/config/reference-data";
 import isEqual from "lodash/isEqual";
@@ -283,7 +283,7 @@ import { createDefaultPaginationParams } from "@/utils/tableHelpers";
 
 export default {
   components: {
-    AddClass,
+    AddCourse,
   },
   data: () => ({
     initialLoad: true,
@@ -387,7 +387,7 @@ export default {
       }
     },
 
-    async addClass(toAdd) {
+    async addCourse(toAdd) {
       this.state.isAddingBusy = true;
 
       toAdd.seats = {

tests/unit/App.spec.js

@@ -38,6 +38,7 @@ describe("Launchboard InitialLoadingApp", () => {
           },
         },
       },
+      stubs: ["router-view"],
       localVue,
       vuetify,
     });
@@ -58,6 +59,7 @@ describe("Launchboard InitialLoadingApp", () => {
           },
         },
       },
+      stubs: ["router-view"],
       localVue,
       vuetify,
     });

tests/unit/components/AddClass.spec.js → tests/unit/components/AddCourse.spec.js

 import { shallowMount } from "@vue/test-utils";
-import AddClass from "@/components/AddClass";
+import AddCourse from "@/components/AddCourse";
 
-describe("LaunchboardAdmin", () => {
+describe("AddCourse", () => {
   it("should emit cancel", async () => {
-    const wrapper = shallowMount(AddClass);
+    const wrapper = shallowMount(AddCourse);
 
     wrapper.vm.cancel();
     await wrapper.vm.$nextTick();
     expect(wrapper.emitted().cancel).toBeTruthy();
   });
   it("should emit add", async () => {
-    const wrapper = shallowMount(AddClass);
+    const wrapper = shallowMount(AddCourse);
 
-    wrapper.vm.addClass();
+    wrapper.vm.addCourse();
     await wrapper.vm.$nextTick();
     expect(wrapper.emitted().add).toBeTruthy();
     expect(wrapper.emitted().add[0]).toEqual([wrapper.vm.toAdd]);
   });
   describe("input validation rules", () => {
-    const wrapper = shallowMount(AddClass);
+    const wrapper = shallowMount(AddCourse);
     it("should check required", () => {
       expect(wrapper.vm.inputRules.required()).toEqual("* Required");
       expect(wrapper.vm.inputRules.required("aaa")).toEqual(true);

tests/unit/components/CurriculumSchedule.spec.js

@@ -18,6 +18,7 @@ describe("CurriculumSchedule", () => {
   });
 
   it("should set loading to false on error", async () => {
+    console.error = jest.fn(); // mock console.error when expecting error messages
     ScheduleService.getScheduleForUser = jest
       .fn()
       .mockRejectedValue("mock error");

tests/unit/components/NavBar.spec.js

@@ -27,6 +27,7 @@ test("NavBar", () => {
         },
       },
     },
+    stubs: ["router-link"],
     localVue,
     vuetify,
   });

tests/unit/components/SystemStatusSummary.spec.js

@@ -21,8 +21,6 @@ test("SystemStatusSummary", () => {
     vuetify,
   });
 
-  wrapper.vm.tempAlert();
-
   // assert the component loads without error
   expect(wrapper.find(".error").exists()).toBe(false);
 });

tests/unit/components/UserSelect.spec.js

@@ -135,9 +135,13 @@ describe("LaunchboardAdmin", () => {
     wrapper.vm.model = null;
     await wrapper.vm.query();
     expect(wrapper.vm.items).toEqual(["a"]);
-
-    // error
+  });
+  it("should set items to empty array on error", async () => {
+    console.error = jest.fn(); // mock console.error when expecting error messages
     UserService.search = jest.fn().mockRejectedValue("mock error");
+    const wrapper = mount(UserSelect, {
+      vuetify,
+    });
     await wrapper.vm.query();
     expect(wrapper.vm.items).toEqual([]);
   });

tests/unit/store/modules/userPreferences.spec.js

@@ -46,6 +46,7 @@ describe("initial-load store", () => {
     );
   });
   it("should fail and throw an error", async () => {
+    console.error = jest.fn(); // mock console.error when expecting error messages
     const mockUserResponse = "mock fail";
     const mockUserPreference = { darkMode: true };
     UserService.updateUserPreferences = jest

tests/unit/views/TrainingDetails.spec.js

@@ -7,20 +7,30 @@ const vuetify = new Vuetify();
 const localVue = createLocalVue();
 localVue.use(Vuex);
 
-test("TrainingDetails", () => {
-  // render the component
-  const wrapper = shallowMount(TrainingDetails, {
-    mocks: {
-      $store: {
-        state: {
-          error: {},
+describe("TrainingDetails", () => {
+  const $route = {
+    params: {
+      trainingId: 42,
+    },
+  };
+
+  it("should not show error by default", () => {
+    // render the component
+    const wrapper = shallowMount(TrainingDetails, {
+      mocks: {
+        $route,
+        $store: {
+          state: {
+            error: {},
+          },
         },
       },
-    },
-    localVue,
-    vuetify,
-  });
+      stubs: ["router-link"],
+      localVue,
+      vuetify,
+    });
 
-  // assert the component loads without error
-  expect(wrapper.find(".error").exists()).toBe(false);
+    // assert the component loads without error
+    expect(wrapper.find(".error").exists()).toBe(false);
+  });
 });

tests/unit/views/super-admin/Personnel.spec.js

@@ -31,7 +31,6 @@ describe("LaunchboardAdmin", () => {
       },
     });
     UserService.updateUserPersonnelType = jest.fn(() => null);
-    window.alert = jest.fn();
     wrapper.vm.$refs.userSelect = {
       clear: jest.fn(),
     };
@@ -104,21 +103,17 @@ describe("LaunchboardAdmin", () => {
   // });
 
   it("should get all list items", async () => {
-    const wrapper = shallowMount(Personnel, {
-      data() {
-        return {
-          personnel: {
-            types: {
-              executiveLeadership: "Executive Leadership",
-              pm: "PM",
-              businessOps: "Business Ops",
-              instructor: "Instructor",
-            },
-          },
-        };
-      },
-    });
+    const wrapper = shallowMount(Personnel);
 
+    wrapper.vm.personnel = {
+      userSelect: {},
+      types: {
+        executiveLeadership: "Executive Leadership",
+        pm: "PM",
+        businessOps: "Business Ops",
+        instructor: "Instructor",
+      },
+    };
     wrapper.vm.$refs.personnel.getPersonnelListItems = jest.fn(() => {
       return [{ personnelType: "Executive Leadership" }];
     });
@@ -172,6 +167,9 @@ describe("LaunchboardAdmin", () => {
       },
     });
     wrapper.setData({ filterSearchValue: "test", filterSelectedValue: "test" });
+    wrapper.vm.$refs.personnel = {
+      fetchData: jest.fn(),
+    };
 
     wrapper.vm.getAllListItems = jest.fn(() => {
       return [

tests/unit/views/super-admin/Training.spec.js

@@ -4,6 +4,10 @@ import TrainingService from "@/api/services/training";
 
 describe("Training", () => {
   const mockCoursesResult = { courses: [], meta: { total: 0 } };
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+
   it("should debounce getCourses", async () => {
     TrainingService.getCourses = jest.fn().mockResolvedValue(mockCoursesResult);
 
@@ -50,7 +54,7 @@ describe("Training", () => {
   //
   //      const wrapper = shallowMount(Training);
   //      const mockClass = { name: "mock class", totalSeats: 55 };
-  //      await wrapper.vm.addClass(mockClass);
+  //      await wrapper.vm.addCourse(mockClass);
   //
   //      expect(TrainingService.addCourse).toHaveBeenCalledTimes(1);
   //      expect(TrainingService.addCourse).toHaveBeenCalledWith(mockClass);
@@ -59,7 +63,7 @@ describe("Training", () => {
   //
   //      // error state
   //      TrainingService.addCourse = jest.fn().mockRejectedValue("mock error");
-  //      await wrapper.vm.addClass(mockClass);
+  //      await wrapper.vm.addCourse(mockClass);
   //      expect(wrapper.vm.state.isAddingBusy).toEqual(false);
   //      expect(wrapper.vm.state.isAdding).toEqual(false);
   //    });