From 1a44a1358c4910067a06f8a55c10dd732b09b0f5 Mon Sep 17 00:00:00 2001 From: ckwolff Date: Mon, 7 Jun 2021 08:46:34 -0600 Subject: [PATCH 01/10] previously could submit a description longer than 2000 chars, but would get internal server error --- src/components/AddCourse.vue | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/components/AddCourse.vue b/src/components/AddCourse.vue index a8ebba7..1787eeb 100644 --- a/src/components/AddCourse.vue +++ b/src/components/AddCourse.vue @@ -26,7 +26,16 @@ hint="* Required" persistent-hint required - :rules="[inputRules.required]" + :rules="[ + inputRules.characterCountWithinRange( + toAdd.name, + { + min: 2, + max: 256, + } + ), + inputRules.required + ]" > Date: Mon, 7 Jun 2021 08:56:54 -0600 Subject: [PATCH 02/10] adding standardization --- src/components/AddCourse.vue | 24 +++++++++--------------- src/views/TrainingDetails.vue | 27 +++++++++++++-------------- 2 files changed, 22 insertions(+), 29 deletions(-) diff --git a/src/components/AddCourse.vue b/src/components/AddCourse.vue index 1787eeb..d21fb82 100644 --- a/src/components/AddCourse.vue +++ b/src/components/AddCourse.vue @@ -27,14 +27,11 @@ persistent-hint required :rules="[ - inputRules.characterCountWithinRange( - toAdd.name, - { - min: 2, - max: 256, - } - ), - inputRules.required + inputRules.characterCountWithinRange(toAdd.name, { + min: 2, + max: 256, + }), + inputRules.required, ]" > @@ -44,13 +41,10 @@ rows="1" v-model="toAdd.description" :rules="[ - inputRules.characterCountWithinRange( - toAdd.description, - { - min: 0, - max: 2001, - } - ), + inputRules.characterCountWithinRange(toAdd.description, { + min: 0, + max: 2001, + }), ]" > diff --git a/src/views/TrainingDetails.vue b/src/views/TrainingDetails.vue index 3e5dd4f..6a209eb 100644 --- a/src/views/TrainingDetails.vue +++ b/src/views/TrainingDetails.vue @@ -59,28 +59,27 @@ v-model="trainingCourseSnapshot.name" label="Edit Course Name" :rules="[ - inputRules.characterCountWithinRange( - trainingCourseSnapshot.name, - { - min: 2, - max: 256, - } - ), + inputRules.characterCountWithinRange(trainingCourseSnapshot.name, { + min: 2, + max: 256, + }), + inputRules.required, ]" > - - + > Date: Mon, 7 Jun 2021 09:08:24 -0600 Subject: [PATCH 03/10] standardizing teams --- src/components/AddTeam.vue | 16 ++++++++++++++-- src/views/TrainingDetails.vue | 31 +++++++++++++++++++------------ 2 files changed, 33 insertions(+), 14 deletions(-) diff --git a/src/components/AddTeam.vue b/src/components/AddTeam.vue index 0f8903e..7fbcb1c 100644 --- a/src/components/AddTeam.vue +++ b/src/components/AddTeam.vue @@ -10,7 +10,13 @@ hint="* Required" persistent-hint required - :rules="[inputRules.required]" + :rules="[ + inputRules.characterCountWithinRange(toAdd.name, { + min: 2, + max: 256, + }), + inputRules.required, + ]" > @@ -74,10 +77,13 @@ counter="2000" rows="1" :rules="[ - inputRules.characterCountWithinRange(trainingCourseSnapshot.description, { - min: 0, - max: 2001, - }), + inputRules.characterCountWithinRange( + trainingCourseSnapshot.description, + { + min: 0, + max: 2001, + } + ), ]" > @@ -449,10 +455,11 @@ export default { }, async fetchStudentData() { try { - const studentResponse = await TrainingService.getCourseRegistrationsById( - this.$route.params.trainingId, - { ...this.params, attendance: true } - ); + const studentResponse = + await TrainingService.getCourseRegistrationsById( + this.$route.params.trainingId, + { ...this.params, attendance: true } + ); this.listItems = studentResponse.registrations?.map((item) => { item.completed = { value: item.completed, loading: false }; -- GitLab From 0faa3b4a33ba8d0a5c1c275256e8f435d3cf4313 Mon Sep 17 00:00:00 2001 From: ckwolff Date: Mon, 7 Jun 2021 09:14:20 -0600 Subject: [PATCH 04/10] linting --- src/components/UserBanner.vue | 35 +++++------------------------------ src/views/TrainingDetails.vue | 9 ++++----- 2 files changed, 9 insertions(+), 35 deletions(-) diff --git a/src/components/UserBanner.vue b/src/components/UserBanner.vue index def6983..8f2e7da 100644 --- a/src/components/UserBanner.vue +++ b/src/components/UserBanner.vue @@ -9,12 +9,7 @@ >