From cfac4779068a62127e6f3e527ea4731f3d6a2dd8 Mon Sep 17 00:00:00 2001 From: Baban Faraj Date: Mon, 30 Aug 2021 12:38:45 -0300 Subject: [PATCH 1/8] Add update to refresh process to utilize skeletonloader --- src/components/ProjectsSummary.vue | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/ProjectsSummary.vue b/src/components/ProjectsSummary.vue index c731513..fa64c03 100644 --- a/src/components/ProjectsSummary.vue +++ b/src/components/ProjectsSummary.vue @@ -284,7 +284,7 @@
- Pipeline: {{ project.latestPipeline.name }} + Pipeline: {{ project.latestPipeline.message }}
@@ -376,6 +376,7 @@ export default { async refreshProjects() { if (this.setProjectLoading) { this.setProjectLoading(true); + this.loading=true; } this.error = false; this.emptyString = false; @@ -395,6 +396,7 @@ export default { } if (this.setProjectLoading) { this.setProjectLoading(false); + this.loading=false; } }, setCardView() { -- GitLab From a60248aed575f8ba54e86b8032f654722615b453 Mon Sep 17 00:00:00 2001 From: Baban Faraj Date: Mon, 30 Aug 2021 12:46:04 -0300 Subject: [PATCH 2/8] Prettier --- src/components/ProjectsSummary.vue | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/components/ProjectsSummary.vue b/src/components/ProjectsSummary.vue index fa64c03..b65d725 100644 --- a/src/components/ProjectsSummary.vue +++ b/src/components/ProjectsSummary.vue @@ -376,7 +376,7 @@ export default { async refreshProjects() { if (this.setProjectLoading) { this.setProjectLoading(true); - this.loading=true; + this.loading = true; } this.error = false; this.emptyString = false; @@ -396,7 +396,7 @@ export default { } if (this.setProjectLoading) { this.setProjectLoading(false); - this.loading=false; + this.loading = false; } }, setCardView() { @@ -459,10 +459,10 @@ export default { padding-bottom: 20px; } .project-card-detail { - padding-top:30px; + padding-top: 30px; padding-bottom: 45px; - padding-left:45px; - padding-right:45px; + padding-left: 45px; + padding-right: 45px; } .card { min-height: 100%; -- GitLab From 35ccd4a596666446b5322a6ec7d9f814aa8e58fb Mon Sep 17 00:00:00 2001 From: Baban Faraj Date: Mon, 30 Aug 2021 13:35:38 -0300 Subject: [PATCH 3/8] Add css to keep fonts of the text from cards consistent --- src/components/ProjectsSummary.vue | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/components/ProjectsSummary.vue b/src/components/ProjectsSummary.vue index b65d725..247ac65 100644 --- a/src/components/ProjectsSummary.vue +++ b/src/components/ProjectsSummary.vue @@ -283,7 +283,7 @@ -
+
Pipeline: {{ project.latestPipeline.message }}
@@ -317,7 +317,9 @@ :key="jIndex" :to="job.link" > - {{ job.name }}; + {{ job.name }}; + @@ -464,6 +466,9 @@ export default { padding-left: 45px; padding-right: 45px; } + .project-card-text { + font-size: medium; + } .card { min-height: 100%; min-width: 100%; -- GitLab From 9e5dbff559b7a3995e56ab211874fe2b02e2fbf2 Mon Sep 17 00:00:00 2001 From: Baban Faraj Date: Mon, 30 Aug 2021 13:53:24 -0300 Subject: [PATCH 4/8] Made the column count for large screen size configurable based on where the project summary is placed. --- src/components/ProjectsSummary.vue | 6 +++- src/views/Projects.vue | 1 + src/views/user/LaunchboardUser.vue | 45 ++++++++++++------------------ 3 files changed, 24 insertions(+), 28 deletions(-) diff --git a/src/components/ProjectsSummary.vue b/src/components/ProjectsSummary.vue index 247ac65..96b288d 100644 --- a/src/components/ProjectsSummary.vue +++ b/src/components/ProjectsSummary.vue @@ -240,7 +240,7 @@ diff --git a/src/views/user/LaunchboardUser.vue b/src/views/user/LaunchboardUser.vue index 03a36bc..6f2d35b 100644 --- a/src/views/user/LaunchboardUser.vue +++ b/src/views/user/LaunchboardUser.vue @@ -60,37 +60,27 @@ headerTitle="My Project Summary" >
- - - Card View - - - - Panel View - + + + Card View + + + + Panel View +
@@ -101,6 +91,7 @@ slot="content" ref="projectSummary" :setProjectLoading="setProjectLoading" + :projectCardColumnLgCount=6 /> -- GitLab From 20b9b97bbaf9a02adcf45141c1e80de2a8b2fab1 Mon Sep 17 00:00:00 2001 From: Baban Faraj Date: Mon, 30 Aug 2021 13:57:29 -0300 Subject: [PATCH 5/8] Fixed icon allignment issue for mobile view --- src/views/Projects.vue | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/views/Projects.vue b/src/views/Projects.vue index 1953673..562461f 100644 --- a/src/views/Projects.vue +++ b/src/views/Projects.vue @@ -12,13 +12,14 @@ :refreshClick="refreshProjectData" >
- +