From 393d4a50635d77b98c6bdd8df31222a98a1d1ebd Mon Sep 17 00:00:00 2001
From: Keith Becker <keith.becker@recro.com>
Date: Mon, 1 Mar 2021 10:03:54 -0700
Subject: [PATCH 1/6] removing usage of lodash

---
 package.json                         | 2 --
 src/api/services/status.js           | 4 +---
 src/store/modules/userPreferences.js | 3 +--
 3 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/package.json b/package.json
index f1ed8f7..71f8060 100644
--- a/package.json
+++ b/package.json
@@ -20,7 +20,6 @@
     "axios": "^0.21.1",
     "core-js": "^3.6.4",
     "downloadjs": "^1.4.7",
-    "lodash": "^4.17.20",
     "vue": "^2.6.11",
     "vue-analytics": "^5.22.1",
     "vue-body-class": "^3.0.2",
@@ -149,7 +148,6 @@
     "faye-websocket": "^0.11.3",
     "sockjs": "^0.3.21",
     "http-proxy": "^1.18.1",
-    "lodash": "^4.17.20",
     "minimist": "^1.2.5",
     "serialize-javascript": "^3.1.0",
     "y18n": "^5.0.5",
diff --git a/src/api/services/status.js b/src/api/services/status.js
index 4f620b2..e0bc750 100644
--- a/src/api/services/status.js
+++ b/src/api/services/status.js
@@ -1,9 +1,7 @@
-import get from "lodash/get";
 import { HTTP } from "@/api/mock-http-common";
 
 export default {
   async getStatusSummary() {
-    const response = await HTTP.get(`status.json`);
-    return get(response, "data.result");
+    return await HTTP.get(`status.json`);
   },
 };
diff --git a/src/store/modules/userPreferences.js b/src/store/modules/userPreferences.js
index e1cd4ee..6a0469c 100644
--- a/src/store/modules/userPreferences.js
+++ b/src/store/modules/userPreferences.js
@@ -1,4 +1,3 @@
-import isNil from "lodash/isNil";
 import { SET_USER_PREFERENCE } from "@/store/mutation-types";
 import { GET_USER_PREFERENCE } from "@/store/getter-types";
 import { CALL_SET_USER_PREFERENCE } from "@/store/action-types";
@@ -31,7 +30,7 @@ const actions = {
 // mutations
 const mutations = {
   [SET_USER_PREFERENCE](_state, userPreference = {}) {
-    if (isNil(userPreference.darkMode)) {
+    if (!(userPreference.darkMode)) {
       userPreference.darkMode = true;
     }
     _state.userPreference = userPreference;
-- 
GitLab


From a7c2a2876328bd016caeec448ed1ff4f2c9cd95c Mon Sep 17 00:00:00 2001
From: Keith Becker <keith.becker@recro.com>
Date: Mon, 1 Mar 2021 10:35:12 -0700
Subject: [PATCH 2/6] remove lodash

---
 src/components/AddTeam.vue           |  3 +--
 src/components/PersonnelTable.vue    | 21 ++++++++-------------
 src/components/UserSelect.vue        |  9 ++++++++-
 src/store/modules/userPreferences.js |  2 +-
 src/views/super-admin/Personnel.vue  |  3 +--
 src/views/super-admin/Teams.vue      |  3 +--
 src/views/super-admin/Training.vue   |  5 ++---
 7 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/src/components/AddTeam.vue b/src/components/AddTeam.vue
index aa062d1..2160b62 100644
--- a/src/components/AddTeam.vue
+++ b/src/components/AddTeam.vue
@@ -97,7 +97,6 @@
   </v-dialog>
 </template>
 <script>
-import cloneDeep from "lodash/cloneDeep";
 import UserSelect from "@/components/UserSelect";
 import inputRules from "@/utils/inputRules";
 
@@ -119,7 +118,7 @@ export default {
   }),
   created() {
     if (this.value) {
-      this.toAdd = cloneDeep(this.value);
+      this.toAdd = Object.assign(this.value);
       this.leads = this.toAdd.members.filter(
         (item) => item.TeamMember.isTeamLead === true
       );
diff --git a/src/components/PersonnelTable.vue b/src/components/PersonnelTable.vue
index f3314be..28ad527 100644
--- a/src/components/PersonnelTable.vue
+++ b/src/components/PersonnelTable.vue
@@ -52,14 +52,10 @@
 </template>
 
 <script>
-import map from "lodash/map";
 import UserService from "@/api/services/user";
-import { defaultSnackbarTimeout, debounceTimeout } from "@/config/config";
+import { debounceTimeout, defaultSnackbarTimeout } from "@/config/config";
 import inputRules from "@/utils/inputRules";
-import toLower from "lodash/toLower";
-import includes from "lodash/includes";
 import Permission from "@/config/user-permissions";
-import isEqual from "lodash/isEqual";
 import {
   DEFAULT_FOOTER_PROPS,
   DEFAULT_PAGINATION_PARAMS,
@@ -220,7 +216,7 @@ export default {
     options: {
       handler(newOptions, prevOptions) {
         // reduce unnecessary api calls
-        if (isEqual(prevOptions, newOptions)) {
+        if (prevOptions == newOptions) {
           return;
         }
 
@@ -244,21 +240,20 @@ export default {
       return this.selectedFilter;
     },
     searchBy() {
-      return toLower(this.searchValue);
+      return this.searchValue.toLowerCase();
     },
     personnelList() {
       const list = [...this.personnel.listItems];
-      const filteredList = list.filter(({ email, number, name }) => {
+      return list.filter(({ email, number, name }) => {
         return (
-          includes(toLower(email), this.searchBy) ||
-          includes(toLower(name), this.searchBy) ||
-          includes(toLower(number), this.searchBy)
+          email.toLowerCase().indexOf(this.searchBy.toLowerCase()) !== -1 ||
+          name.toLowerCase().indexOf(this.searchBy.toLowerCase()) !== -1 ||
+          number.toLowerCase().indexOf(this.searchBy.toLowerCase()) !== -1
         );
       });
-      return filteredList;
     },
     permissionTypesDropdown() {
-      return map(this.permissionTypes, (label) => {
+      return this.permissionTypes.map((label) => {
         return { text: label, value: label };
       });
     },
diff --git a/src/components/UserSelect.vue b/src/components/UserSelect.vue
index bb867ad..d8f986a 100644
--- a/src/components/UserSelect.vue
+++ b/src/components/UserSelect.vue
@@ -62,9 +62,16 @@
 
 <script>
 import UserService from "@/api/services/user";
-import uniq from "lodash/uniq";
 import { setInputElementFocus } from "@/utils/events";
 
+function uniq(a) {
+  function onlyUnique(value, index, self) {
+    return self.indexOf(value) === index;
+  }
+
+  return a.filter(onlyUnique);
+}
+
 export default {
   props: {
     multiple: {
diff --git a/src/store/modules/userPreferences.js b/src/store/modules/userPreferences.js
index 6a0469c..ca467f5 100644
--- a/src/store/modules/userPreferences.js
+++ b/src/store/modules/userPreferences.js
@@ -30,7 +30,7 @@ const actions = {
 // mutations
 const mutations = {
   [SET_USER_PREFERENCE](_state, userPreference = {}) {
-    if (!(userPreference.darkMode)) {
+    if (!userPreference.darkMode) {
       userPreference.darkMode = true;
     }
     _state.userPreference = userPreference;
diff --git a/src/views/super-admin/Personnel.vue b/src/views/super-admin/Personnel.vue
index ca85a11..e1decbe 100644
--- a/src/views/super-admin/Personnel.vue
+++ b/src/views/super-admin/Personnel.vue
@@ -158,7 +158,6 @@
 </template>
 
 <script>
-import map from "lodash/map";
 import download from "downloadjs";
 import UserSelect from "@/components/UserSelect";
 import UserService from "@/api/services/user";
@@ -310,7 +309,7 @@ export default {
   },
   computed: {
     filterItemDropdown() {
-      return map(this.personnelTypes, (label, key) => {
+      return this.personnelTypes.map((label, key) => {
         return { text: label, value: key };
       });
     },
diff --git a/src/views/super-admin/Teams.vue b/src/views/super-admin/Teams.vue
index 908940e..c1ca37e 100644
--- a/src/views/super-admin/Teams.vue
+++ b/src/views/super-admin/Teams.vue
@@ -200,7 +200,6 @@ import Vue from "vue";
 import TeamService from "@/api/services/team";
 import AddTeam from "@/components/AddTeam";
 import { defaultSnackbarTimeout, debounceTimeout } from "@/config/config";
-import isEqual from "lodash/isEqual";
 import { setInputElementFocus } from "@/utils/events";
 import {
   DEFAULT_FOOTER_PROPS,
@@ -259,7 +258,7 @@ export default {
     options: {
       handler(newOptions, prevOptions) {
         // reduce unnecessary api calls
-        if (isEqual(prevOptions, newOptions)) {
+        if (prevOptions == newOptions) {
           return;
         }
 
diff --git a/src/views/super-admin/Training.vue b/src/views/super-admin/Training.vue
index ffb3fb5..bd73517 100644
--- a/src/views/super-admin/Training.vue
+++ b/src/views/super-admin/Training.vue
@@ -252,7 +252,7 @@
             </v-btn>
           </template>
         </v-snackbar>
-        <v-snackbar
+       <v-snackbar
           top
           v-if="courseToAdd"
           v-model="snackbars.add"
@@ -270,7 +270,6 @@ import TrainingService from "@/api/services/training";
 import AddCourse from "@/components/AddCourse";
 import { defaultSnackbarTimeout, debounceTimeout } from "@/config/config";
 import { trainingTypes } from "@/config/reference-data";
-import isEqual from "lodash/isEqual";
 import { setInputElementFocus } from "@/utils/events";
 import {
   DEFAULT_FOOTER_PROPS,
@@ -338,7 +337,7 @@ export default {
     options: {
       handler(newOptions, prevOptions) {
         // reduce unnecessary api calls
-        if (isEqual(prevOptions, newOptions)) {
+        if (prevOptions == newOptions) {
           return;
         }
 
-- 
GitLab


From 636b9414ee44173f9b0c9f437d84124339f30014 Mon Sep 17 00:00:00 2001
From: Keith Becker <keith.becker@recro.com>
Date: Mon, 1 Mar 2021 10:36:20 -0700
Subject: [PATCH 3/6] prettier

---
 src/views/super-admin/Training.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/views/super-admin/Training.vue b/src/views/super-admin/Training.vue
index bd73517..ad45bcd 100644
--- a/src/views/super-admin/Training.vue
+++ b/src/views/super-admin/Training.vue
@@ -252,7 +252,7 @@
             </v-btn>
           </template>
         </v-snackbar>
-       <v-snackbar
+        <v-snackbar
           top
           v-if="courseToAdd"
           v-model="snackbars.add"
-- 
GitLab


From c1ce618e02cb34a2094f7d1636a35ef964315cf5 Mon Sep 17 00:00:00 2001
From: Keith Becker <keith.becker@recro.com>
Date: Mon, 1 Mar 2021 10:40:15 -0700
Subject: [PATCH 4/6] remove usage of lodash

---
 src/views/super-admin/Personnel.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/views/super-admin/Personnel.vue b/src/views/super-admin/Personnel.vue
index e1decbe..25ed462 100644
--- a/src/views/super-admin/Personnel.vue
+++ b/src/views/super-admin/Personnel.vue
@@ -309,8 +309,8 @@ export default {
   },
   computed: {
     filterItemDropdown() {
-      return this.personnelTypes.map((label, key) => {
-        return { text: label, value: key };
+      return this.personnelTypes.map((label) => {
+        return { text: label, value: label };
       });
     },
   },
-- 
GitLab


From 65002de2dd385abfcb88d7c98a16650f066277ba Mon Sep 17 00:00:00 2001
From: Keith Becker <keith.becker@recro.com>
Date: Mon, 1 Mar 2021 10:43:24 -0700
Subject: [PATCH 5/6] removing usage of lodash

---
 tests/unit/mock-router.js | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/tests/unit/mock-router.js b/tests/unit/mock-router.js
index cc1d107..cc9048e 100644
--- a/tests/unit/mock-router.js
+++ b/tests/unit/mock-router.js
@@ -1,15 +1,12 @@
 import routes from "@/router/routes";
 import VueRouter from "vue-router";
-// import { mockRouterComponents } from "vue-test-utils-helpers";
-
-import cloneDeep from "lodash/clonedeep";
 
 // from https://github.com/AmpleOrganics/vue-test-utils-helpers/blob/master/src/mockRouterComponents.js
 function mockRouterComponents(
   routesToMock,
   dummyComponent = { template: "<p>Foo</p>" }
 ) {
-  const routesToClear = cloneDeep(routesToMock);
+  const routesToClear = Object.assign(routesToMock);
   routesToClear.forEach((route) => {
     route.component = dummyComponent;
     if (route.children && route.children.length) {
-- 
GitLab


From b58411150424b7d4e08e766589ba37112264bf8c Mon Sep 17 00:00:00 2001
From: Keith Becker <keith.becker@recro.com>
Date: Mon, 1 Mar 2021 10:51:17 -0700
Subject: [PATCH 6/6] remove usage of lodash

---
 src/components/PersonnelTable.vue   | 10 +++++++---
 src/views/super-admin/Personnel.vue | 10 +++++++---
 2 files changed, 14 insertions(+), 6 deletions(-)

diff --git a/src/components/PersonnelTable.vue b/src/components/PersonnelTable.vue
index 28ad527..a50d462 100644
--- a/src/components/PersonnelTable.vue
+++ b/src/components/PersonnelTable.vue
@@ -253,9 +253,13 @@ export default {
       });
     },
     permissionTypesDropdown() {
-      return this.permissionTypes.map((label) => {
-        return { text: label, value: label };
-      });
+      if (Array.isArray(this.permissionTypes)) {
+        return this.permissionTypes.map((label) => {
+          return { text: label, value: label };
+        });
+      } else {
+        return [];
+      }
     },
   },
 };
diff --git a/src/views/super-admin/Personnel.vue b/src/views/super-admin/Personnel.vue
index 25ed462..a701015 100644
--- a/src/views/super-admin/Personnel.vue
+++ b/src/views/super-admin/Personnel.vue
@@ -309,9 +309,13 @@ export default {
   },
   computed: {
     filterItemDropdown() {
-      return this.personnelTypes.map((label) => {
-        return { text: label, value: label };
-      });
+      if (Array.isArray(this.personnelTypes)) {
+        return this.personnelTypes.map((label) => {
+          return { text: label, value: label };
+        });
+      } else {
+        return [];
+      }
     },
   },
 };
-- 
GitLab