From f7bb2f94abb8e4ad07d47054546645239daa526a Mon Sep 17 00:00:00 2001
From: Luke Glasscock <luke.glasscock@ascellatech.com>
Date: Mon, 1 Mar 2021 13:15:50 -0700
Subject: [PATCH 1/2] Hide table footer when no data exists

---
 src/components/PersonnelTable.vue  | 1 +
 src/views/super-admin/Teams.vue    | 3 ++-
 src/views/super-admin/Training.vue | 3 ++-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/components/PersonnelTable.vue b/src/components/PersonnelTable.vue
index f3314be..f6d500b 100644
--- a/src/components/PersonnelTable.vue
+++ b/src/components/PersonnelTable.vue
@@ -16,6 +16,7 @@
       :options.sync="options"
       :footer-props="footerProps"
       :server-items-length="total"
+      :hide-default-footer="personnelList.length === 0"
     >
       <template v-slot:[`item.permission`]="{ item }">
         <span v-if="userPermission !== permissionTypes.SUPER_ADMIN">
diff --git a/src/views/super-admin/Teams.vue b/src/views/super-admin/Teams.vue
index 908940e..ddfb2e1 100644
--- a/src/views/super-admin/Teams.vue
+++ b/src/views/super-admin/Teams.vue
@@ -20,6 +20,7 @@
           mobile-breakpoint="800"
           loading-text="Loading Teams ..."
           class="background-transparent position-relative"
+          :hide-default-footer="selectedTeams.length === 0"
         >
           <template v-slot:top>
             <div
@@ -120,7 +121,7 @@
           </template>
         </v-data-table>
 
-        <div class="d-flex flex-wrap mb-3">
+        <div class="d-flex flex-wrap mt-5 mb-3">
           <v-tooltip top>
             <template v-slot:activator="{ on, attrs }">
               <v-btn
diff --git a/src/views/super-admin/Training.vue b/src/views/super-admin/Training.vue
index ffb3fb5..1cd7ba5 100644
--- a/src/views/super-admin/Training.vue
+++ b/src/views/super-admin/Training.vue
@@ -20,6 +20,7 @@
           mobile-breakpoint="800"
           loading-text="Loading Courses..."
           class="background-transparent position-relative"
+          :hide-default-footer="selectedCourses === 0"
         >
           <template v-slot:top>
             <div
@@ -189,7 +190,7 @@
           </template>
         </v-data-table>
 
-        <div class="d-flex flex-wrap mb-3">
+        <div class="d-flex flex-wrap mt-5 mb-3">
           <v-tooltip top>
             <template v-slot:activator="{ on, attrs }">
               <v-btn
-- 
GitLab


From f12f8cd6ff060bb6cb3dab4b25c9832ab611ed7e Mon Sep 17 00:00:00 2001
From: Luke Glasscock <luke.glasscock@ascellatech.com>
Date: Mon, 1 Mar 2021 14:45:58 -0700
Subject: [PATCH 2/2] Update tests

---
 tests/unit/components/PersonnelTable.spec.js | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tests/unit/components/PersonnelTable.spec.js b/tests/unit/components/PersonnelTable.spec.js
index cbdfc52..9520fbd 100644
--- a/tests/unit/components/PersonnelTable.spec.js
+++ b/tests/unit/components/PersonnelTable.spec.js
@@ -26,7 +26,7 @@ describe("PersonnelTable", () => {
       .fn()
       .mockResolvedValue(mockUsersResponse);
 
-    UserService.updateUserPersonnelType = jest.fn().mockResolvedValue();
+    UserService.updateUserPersonnelType = jest.fn().mockResolvedValue([]);
 
     const store = new Vuex.Store({
       state: {
@@ -37,6 +37,14 @@ describe("PersonnelTable", () => {
     });
 
     const wrapper = shallowMount(PersonnelTable, {
+      data() {
+        return {
+          personnel: {
+            listItems: [{ id: 1 }],
+          },
+          params: {},
+        };
+      },
       store,
       localVue,
     });
@@ -79,7 +87,7 @@ describe("PersonnelTable", () => {
       .mockResolvedValue({ users: [], meta: { total: 0 } });
 
     const wrapper = shallowMount(PersonnelTable);
-    await wrapper.vm.fetchData({});
+    await wrapper.vm.fetchData({ personnelType: "test" });
     expect(wrapper.vm.personnel.listItems).toEqual([]);
   });
 
-- 
GitLab