Merge branch 'global-addons' into 'master'

Updated bb values.yaml to have a global value for image pull policy for all addons

Closes #938

See merge request platform-one/big-bang/bigbang!1144

chart/templates/anchore/values.yaml

@@ -43,6 +43,7 @@ sso:
   {{- end }}
 
 anchoreEnterpriseGlobal:
+  imagePullPolicy: {{ .Values.imagePullPolicy }}
   enabled: {{ .Values.addons.anchore.enterprise.enabled }}
   imagePullSecretName: private-registry
 
@@ -57,6 +58,7 @@ postgresql:
   {{- end }}
 
 anchoreGlobal:
+  imagePullPolicy: {{ .Values.imagePullPolicy }}
   openShiftDeployment: {{ .Values.openshift }}
   {{- if .Values.addons.anchore.adminPassword }}
   defaultAdminPassword: {{ .Values.addons.anchore.adminPassword }}
@@ -75,6 +77,7 @@ anchore-feeds-db:
   {{- end }}
 
 anchoreEnterpriseUi:
+  imagePullPolicy: {{ .Values.imagePullPolicy }}
   imagePullSecretName: private-registry
 
 anchore-ui-redis:

chart/templates/argocd/values.yaml

@@ -11,22 +11,38 @@ domain: {{ $domainName }}
 createNamespace: false
 
 global:
+  image: 
+    imagePullPolicy: {{ .Values.imagePullPolicy }}
   imagePullSecrets:
     - name: private-registry
 
 controller:
+  image: 
+    imagePullPolicy: {{ .Values.imagePullPolicy }}
   imagePullSecrets:
     - name: private-registry
 
 dex:
+  image: 
+    imagePullPolicy: {{ .Values.imagePullPolicy }}
   imagePullSecrets:
     - name: private-registry
 
 redis-bb:
+  image: 
+    pullPolicy: {{ .Values.imagePullPolicy }}
   enabled: true
   auth:
     enabled: false
 
+server:
+  image: 
+    imagePullPolicy: {{ .Values.imagePullPolicy }}
+
+repoServer:
+  image: 
+    imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 istio:
   enabled: {{ .Values.istio.enabled }}
   argocd:

chart/templates/authservice/values.yaml

@@ -6,6 +6,9 @@
 # hostname is deprecated and replaced with domain. But if hostname exists then use it.
 {{- $domainName := default .Values.domain .Values.hostname }}
 
+image: 
+  pullPolicy: {{ .Values.imagePullPolicy }}
+  
 imagePullSecrets:
   - name: private-registry
 

chart/templates/gitlab-runner/values.yaml

@@ -3,6 +3,9 @@
 {{- end }}
 
 {{- define "bigbang.defaults.gitlab-runner" -}}
+
+imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 imagePullSecrets:
 - name: private-registry
 

chart/templates/gitlab/values.yaml

@@ -74,6 +74,9 @@ gitlab:
 global:
 
   # added to help with Gitlab sub-chart configuration
+  image:
+    pullPolicy: {{ .Values.imagePullPolicy }}
+    
   istio:
     enabled: {{ .Values.istio.enabled }}
     injection: {{ dig "istio" "injection" "enabled" .Values.addons.gitlab }}

chart/templates/keycloak/values.yaml

@@ -8,6 +8,9 @@ replicas: 2
 imagePullSecrets:
 - name: private-registry
 
+image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+
 # hostname is deprecated and replaced with domain. But if hostname exists then use it.
 {{- $domainName := default .Values.domain .Values.hostname }}
 hostname: {{ $domainName }}

chart/templates/mattermost/mattermost/values.yaml

@@ -10,6 +10,9 @@ domain: {{ $domainName }}
 
 openshift: {{ .Values.openshift }}
 
+image:
+  imagePullPolicy: {{ .Values.imagePullPolicy }}
+  
 istio:
   enabled: {{ .Values.istio.enabled }}
   chat:

chart/templates/mattermost/operator/values.yaml

@@ -6,6 +6,9 @@
 imagePullSecrets:
   - name: private-registry
 
+image:
+  imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 networkPolicies:
   enabled: {{ .Values.networkPolicies.enabled }}
   controlPlaneCidr: {{ .Values.networkPolicies.controlPlaneCidr }}

chart/templates/minio/minio-operator/values.yaml

@@ -11,6 +11,10 @@ podAnnotations:
 imagePullSecrets:
   - name: private-registry
 
+operator:
+  image:
+    pullPolicy: {{ .Values.imagePullPolicy}}
+    
 networkPolicies:
   enabled: {{ .Values.networkPolicies.enabled }}
   controlPlaneCidr: {{ .Values.networkPolicies.controlPlaneCidr }}

chart/templates/minio/minio/values.yaml

@@ -36,6 +36,8 @@ podAnnotations:
   traffic.sidecar.istio.io/excludeInboundPorts: "9443"
 
 tenants:
+  image:
+    pullPolicy: {{ .Values.imagePullPolicy }}
   imagePullSecret:
     name: private-registry
   secrets:

chart/templates/nexus-repository-manager/values.yaml

@@ -14,6 +14,12 @@ istio:
 
 openshift: {{ .Values.openshift }}
 
+image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+
+job_image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+  
 monitoring:
   enabled: {{ .Values.monitoring.enabled }}
 

chart/templates/sonarqube/values.yaml

@@ -26,6 +26,7 @@ networkPolicies:
     {{- toYaml (dig "values" "gateways" $gateway "selector" $default .Values.istio) | nindent 4 }}
 
 image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
   pullSecret: private-registry
 
 {{- if .Values.addons.sonarqube.sso.enabled }}

chart/templates/velero/values.yaml

@@ -17,6 +17,9 @@ networkPolicies:
 imagePullSecrets:
 - name: private-registry
 
+image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+
 {{- if eq (len .Values.addons.velero.plugins) 0 }}{{- fail "At least one plugin in '.Values.addons.velero.plugins' required. Supported values: aws, azure, csi" }}{{- end }}
 initContainers:
 {{- range .Values.addons.velero.plugins }}

docs/guides/using_bigbang/image_pull_policy.md

@@ -2,9 +2,7 @@
 
 Big Bang is currently working to standardize the adoption of a global image pull policy so that customers can set a single value and have it passed to all packages.
 
-The global image pull policy has been adopted in Big Bang for the core packages currently. In the Big Bang values.yaml file, a global parameter has been created to set the global image pull policy (`imagePullPolicy` in values) and it gets passed down to all core packages spec. The default value for this global policy is `IfNotPresent`.
-
-This work is not yet complete for addons, but should allow customers easier control over their global pull policy.
+The global image pull policy has been adopted in Big Bang for the core packages and for addons. In the Big Bang values.yaml file, a global parameter has been created to set the global image pull policy (`imagePullPolicy` in values) and it gets passed down to all core packages and addons spec. The default value for this global policy is `IfNotPresent`.
 
 We have also documented the package overrides required if you want to set a single package/pod with a different pull policy than the global.