Clean up Flux precedence "dead code"
Currently we have a layer of ordering/precedence code that duplicates what would already be done by Flux:
- https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/c8abac6087affe21dc64a975a7d6ae35afe63d70/chart/templates/_helpers.tpl#L37-54 : This is the precedence code we have
- https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/334baa0dd685994646bacf9c9af20dfbf03d3136/chart/templates/monitoring/gitrepository.yaml#L15 : Each gitrepo references these here
By removing this helper and switching to a direct values passthrough from <package>.git.tag, <package>.git.branch, etc, we can rely on the way Flux handles precedence of these values, without adding our own confusing layer in there.
This may be best to do as part of the switch from GitRepo -> HelmRepository since that's an easy change to refactor.
We should also document this default precedence and how to point to a branch instead of a tag (i.e. nulling out the tag value).
Activity
@micah.nagel this issue has been inactive for 30 days and is being labelled as stale. If this issue is still required please take action by removing the stale label and commenting with an update, status, or justification. If this issue is not required please close it or label it as delete-me. If no action is taken this issue will be auto closed in 60 days.
added stale label
removed stale label
added teamcore/security label
-
@micah.nagel this issue has been inactive for 30 days and is being labelled as stale. If this issue is still required please take action by removing the stale label and commenting with an update, status, or justification. If this issue is not required please close it or label it as delete-me. If no action is taken this issue will be auto closed in 60 days.
added stale label
removed stale label
-
@micah.nagel this issue has been inactive for 30 days and is being labelled as stale. If this issue is still required please take action by removing the stale label and commenting with an update, status, or justification. If this issue is not required please close it or label it as delete-me. If no action is taken this issue will be auto closed in 60 days.
added stale label
-
@micah.nagel this issue has been inactive for 60 days and is being labelled as marked-for-auto-close. If this issue is still required please take action by removing the stale and marked-for-auto-close labels and commenting with an update, status, or justification. If this issue is not required please close it or label it as delete-me. If no action is taken this issue will be auto closed in 30 days.
added marked-for-auto-close label
added delete-me label
-
@micah.nagel this issue has been closed due to the label delete-me.
mentioned in merge request big-bang/product/packages/twistlock!169 (merged)
