Kyverno images missing from 2.12.0 packages-image.yaml release artifact

added kindbug priority3 labels and removed triage-kind triage-priority labels

changed iteration to Big Bang Iterations Oct 17, 2023 - Oct 30, 2023

changed milestone to %2.14.0

These images are provided in the bundle of BigBang as a whole. If needed specifically for kyverno we can facilitate this request but that is the reason these "helper" you could call them, images aren't included with every package by default.

removed iteration Big Bang Iterations Oct 17, 2023 - Oct 30, 2023

changed iteration to Big Bang Iterations Oct 31, 2023 - Nov 13, 2023

changed milestone to %2.15.0

assigned to @seagren.tim

So after digging into this a bit, it seems as though while we validate that all images (minus any k3d dependency images) pulled from the k3d cluster hosting the package deployment are present in Chart.yaml's helm.sh/images annotation, we do not perform the inverse check to ensure that all images defined in Chart.yaml are found in the package-images.txt. This leaves the door open for images that are used in non-standard deployments of a package to be left out of package-images.txt.

This be desirable in some cases, such as for images that are only used by BigBang tests/ resources, which would probably not be interesting to end users, but in this case we also missed the "helper" kubectl image, which could be used depending on package configuration.

Legend for roles of the various files involved with this:

dependencies.txt - a list of images collected from k3d's container runtime before the package is deployed
full-list.txt - a list of images collected from k3d's container runtime after the package is deployed
package-images.txt - full-list.txt - dependencies.txt
Chart.yaml's helm.sh/images annotation - a list of all images that could possibly be used across deployment scenarios, which is forcefully kept up-to-date by comparing package-images.txt to helm.sh/images

To resolve this we could, after performing the validation of the content of helm.sh/images, add any images not already in package-images.txt from helm.sh/images to package-images.txt. Thoughts @ryan.j.garcia @chris.oconnell @michaelmartin?

I think that would be best. If these are required for a specific package but not grabbed via CI or listed in the helm.sh/images we can place them in tests/images.txt and CI will bundle them.

kubectl and ubi8-minimal are both in helm.sh/images, so we should be good without a tests/images.txt in the Kyverno case if we start adding anything missing from helm.sh/images to package-images.txt. I'll make an MR to the pipeline to get that going.