Feature Request: Make Gitlab Object Storage Endpoint Configurable for IAM Profile
Feature Request
Why
I am currently encountering an issue with configuring Gitlab object storage on the high side. The endpoint for AWS s3 can change depending on what AWS region/partition you are deploying into.
I am trying to using IAM profiles rather than access keys to configure Gitlab object storage. However, the endpoint variable appears to be tied to access keys for some reason.
Found an older issue about this issue that closed without a fix: #1470 (closed)
Proposed Solution
Essentially would like to see the endpoint treated as a standalone config option that isn't dependent on accessKey/accessSecret as it needs to be configurable when using IAM profiles as well.
Solution from above issue:
{{- else if eq .Values.addons.gitlab.objectStorage.iamProfile "" }}
aws_access_key_id: {{ .Values.addons.gitlab.objectStorage.accessKey }}
aws_secret_access_key: {{ .Values.addons.gitlab.objectStorage.accessSecret }}
{{- end }}
{{- if .Values.addons.gitlab.objectStorage.endpoint }}
endpoint: "{{ .Values.addons.gitlab.objectStorage.endpoint }}"
{{- end }}