Authservice Redirect URLs don't respect virtual service name overrides

Packages can override the hostname for virtual services, but that override is not respected in authservice config:

https://repo1.dso.mil/platform-one/big-bang/bigbang/-/blob/master/chart/templates/authservice/values.yaml#L41

added authservice istio jaeger monitoring labels

added kindbug priority6 labels

assigned to @ryan.j.garcia

created merge request !350 (merged) to address this issue

mentioned in merge request !350 (merged)

added statusdoing label

added to epic &66 (closed)

changed milestone to %1.6.0

changed iteration to Big Bang Iterations Apr 6, 2021 - Apr 20, 2021

@joshwolf @runyontr Tagging you guys as it seems Authservice can not handle multiple "prefix" headers to match, and multiple URIs in "callback_uri" for a single chain. For this issue do we want to have the ability for people to add multiple kiali/jaeger/prometheus/alertmanager URIs to work with authservice or just a single one? Multiple would match the VirtualService support in most packages (istio.hosts sections) but will complicate the authservice chain creation.

Adding support for multiple is possible but will require quite a few changes to the authservice values that a new chain for each URI will have to be created, each with their own declarations for match, callback_uri, client_id, etc.

HAProxy looks to support multiple URIs per acl line so that config should be simpler to add.

changed milestone to %1.7.0

changed iteration to Big Bang Iterations Apr 21, 2021 - May 4, 2021

set weight to 2

changed title from Authservice Redirect URLs dont respect virtual service name overrides to Authservice Redirect URLs don't respect virtual service name overrides

changed milestone to %1.8.0

changed iteration to Big Bang Iterations May 5, 2021 - May 18, 2021

@ryan.j.garcia would this be scoped to only BigBang-generated/managed apps that have a VS backed by authservice? Like you said, the secret template would get pretty hair managing it, but it's not out of the question.

Do you have an example values.yaml of one of those apps using multiple hosts?

Hi @adam.toy , Yeah this would be only for the bigbang provided apps that are behind authservice.

Which as of the current release is only prometheus, alertmanager, jaeger, and kiali.

Won't be an issue if filling in your own authservice chain via the authservice values.

And while it may not be actively being used, all bigbang packages support multiple hostnames per VS eg: https://repo1.dso.mil/platform-one/big-bang/apps/core/monitoring/-/blob/main/chart/values.yaml#L21

Continuing work on ticket with support for modification of single URL for BigBang provided Authservice protected apps.

closed with merge request !350 (merged)

mentioned in commit 75f7c23e

removed statusdoing label