Minor: Inconsistent syntax for enabling monitoring within BigBang packages
When enabling the monitoring for the packages included in bigbang, I noticed some inconsistencies in how each package is enabled.
Using the configmap.yaml in the customer template, for example Gitlab monitoring is enabled overwriting the value in values.yaml chart
gitlab:
enabled: true
git:
repo: https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab.git
path: "./chart"
tag: "4.8.0-bb.0"
values:
postgresql:
install: true
monitoring:
enabled: true
for twistlock it is enabled by adding prometheus to the values
twistlock:
values:
console:
persistence:
size: 5Gi
prometheus:
servicemonitor:
enabled: true
and for anchore it is enabled by adding enabled:true but also adding the namespace.
anchore:
enabled: true
values:
monitoring:
enabled: true
namespace: monitoring
It would be more clear to customers using the template if all packages followed the same enabling convention as gitlab, and many of the other packages do, but not all.
This is not affecting the functionality and this issue is very minor, but thought I would give my feedback.