Nexus repo creation
Summary
Nexus-Repository-Manager additional feature: This addition to Big Bang Nexus allows the user add multiple or a single raw repository when nexus is enable for the first time as an addon within Big Bang. addons.nexus.repository is required to be enabled.
Merge request reports
Activity
- Resolved by kevin.wilder
@kevin.wilder This is a MR to add repos for nexus and this MR is somewhat between your additions and our additions. Not sure how you would like to coordinate.
added 54 commits
-
06fbc841...0e31943d - 53 commits from branch
master
- 179428e6 - Merge branch 'master' into nexus-repo-creation
-
06fbc841...0e31943d - 53 commits from branch
added 5 commits
-
179428e6...e6318331 - 4 commits from branch
master
- 9c508856 - Added recent changes to master.
-
179428e6...e6318331 - 4 commits from branch
added statusreview label
assigned to @rarencibia and @andrew.yeilding
added 5 commits
-
9c508856...f19250dd - 4 commits from branch
master
- 1effdcd0 - Merge branch 'master' into nexus-repo-creation
-
9c508856...f19250dd - 4 commits from branch
added 3 commits
-
1effdcd0...10d43bea - 2 commits from branch
master
- 3250fc59 - Merge branch 'master' into nexus-repo-creation
-
1effdcd0...10d43bea - 2 commits from branch
Typically, we keep changes in the Big Bang values/chart limited to general features that apply across all packages (if they support it). For application specific settings, we refer the users to the upstream chart and use
.Values.<package>.values
. This seems to me to be Nexus specific and not applicable to other applications. So, I don't think we should add this in place.Maybe this would be better served in the Nexus repository?
Hey @michaelmcleroy I want to make sure I am understanding. Are you referencing
chart/values.yaml
orchart/templates/nexus-repository-manager/values.yaml
. As the additions inchart/templates/nexus-repository-manager/values.yaml
is necessary for this feature.I think what Michael is saying is that typically we only add changes to BB values (
chart/values.yaml
) for general stuff that could be in most packages (ex: database storage values, sso values).For these changes it would be preferred if we just leave them as options in the nexus chart (the changes you have done here). Once those changes in the nexus chart are merged and a new nexus tag is released we can update the BB default tag for nexus to that new version. Then all the values you've added in the nexus chart will be available to anyone who wants to use them, without these additional changes to
chart/templates/nexus-repository-manager/values.yaml
orchart/values.yaml
.The
addons.nexus.values
helm value allows customers to pass anything through to the package charts. So for this change you'd pass in:addons: nexus: values: repository: enabled: true repo: - name: "test-nexus2" format: "raw" type: "hosted" repo_data: name: "test-nexus2" online: true storage: blobStoreName: "default" strictContentTypeValidation: true writePolicy: "allow_once" cleanup: policyNames: - "string" component: proprietaryComponents: true raw: contentDisposition: "ATTACHMENT"
This would have the same effect as if you passed in those values directly in nexus' chart/values.yaml.
added 19 commits
-
3250fc59...02ab0027 - 18 commits from branch
master
- 5d27058a - Merge branch 'master' into nexus-repo-creation
-
3250fc59...02ab0027 - 18 commits from branch
requested review from @ryan.j.garcia and @micah.nagel
added 5 commits
-
5d27058a...7b14b473 - 4 commits from branch
master
- aa827bc3 - Merge branch 'master' into nexus-repo-creation
-
5d27058a...7b14b473 - 4 commits from branch
added statusdoing label and removed statusreview label
Hey @micah.nagel @michaelmcleroy I was able to modify and use the values section of nexus. I am going to close this merge request, as I no longer need these additions to this repo. Thank you for your guidance @micah.nagel.
mentioned in merge request !1115 (merged)