UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

Add istio-version in pod annotations for authservice pods

Merged Add istio-version in pod annotations for authservice pods
967-annotate-authservice-pods-with-istio-version into master
1 unresolved thread
Merged Noah Costello requested to merge 967-annotate-authservice-pods-with-istio-version into master
1 unresolved thread
Compare
and
1 file
+ 3
− 0
Compare changes
  • Side-by-side
  • Inline
chart/templates/authservice/values.yaml
+ 3
− 0
@@ -12,6 +12,9 @@ image:
imagePullSecrets:
- name: private-registry
podAnnotations:
{{ include "istioAnnotation" . }}
    • Micah Nagel
      Micah Nagel @micah.nagel ·
      Guest

      2 super small things on this one...

      • we can probably just drop the conditional here since authservice is entirely conditional on istio (see line 1, this won't even be created if Istio is disabled)
      • the indentation here comes out funny in the secret, since everything else is indented 2 spaces per "level" and this comes out to 4 (the template will output the annotation starting at the 1st curly brace essentially)

      Both really small but I think worth the quick update.

      Suggested change
      Applied
      13 podAnnotations:
      14 {{- if .Values.istio.enabled }}
      15 {{ include "istioAnnotation" . }}
      16 {{- end }}
      17
      13 podAnnotations:
      14 {{ include "istioAnnotation" . }}
      15
      Edited by Micah Nagel
Please register or sign in to reply
openshift: {{ .Values.openshift }}
networkPolicies:

UNCLASSIFIED - NO CUI