UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

Patch gateway hosts

Merged Tim Seagren requested to merge patch-gateway-hosts into master
All threads resolved!

Package Merge Request

Package Changes

Updates the istio global values, secret-tls.yaml template, gateway.yaml template, and values.yaml template files in chart/templates/istio/controlplane/ to support using two different TLS certificate secrets for the same Gateway resource.

Package MR

N/A

For Issue

Closes #1068 (closed)

BB Processes

Add labels for affected packages so that they are deployed in CI as well as a status label:

Be sure to assign to yourself:

Once it is ready for review switch the status and assign reviewers:

Edited by Ryan Garcia

Merge request reports

Merge request pipeline #698315 passed

Merge request pipeline passed for a35df163

Merged by Ryan GarciaRyan Garcia 3 years ago (Feb 23, 2022 8:53pm UTC)

Merge details

Pipeline #698454 failed

Pipeline failed for 7a7aed7a on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Tim Seagren

      Since we'd be deprecating the old way, add a conditional in NOTES.txt to spit out a deprecation warning if the old way is used. I think you'll have to use range there to iterate over each gateway and spit out the warning for each gateway using the deprecated method.

  • Michael McLeroy
  • mentioned in issue #1068 (closed)

  • Tim Seagren changed the description

    changed the description

  • Tim Seagren added 1 commit

    added 1 commit

    • a662f498 - updating values.yaml to support old method by default, updating...

    Compare with previous version

  • Tim Seagren added 1 commit

    added 1 commit

    • bf2fde61 - updating defaults to not create nonsense ports

    Compare with previous version

  • Author Contributor

    @michaelmcleroy changes have been made, whenever you get a second

  • Tim Seagren marked this merge request as ready

    marked this merge request as ready

  • Tim Seagren resolved all threads

    resolved all threads

  • @micah.nagel, @BrandenCobb, and @ryan.j.garcia could one of you please take a look at this MR?

  • Micah Nagel resolved all threads

    resolved all threads

  • Micah Nagel added 95 commits

    added 95 commits

    Compare with previous version

  • Micah Nagel
  • Tim Seagren added 1 commit

    added 1 commit

    • 36093bcf - replacing the missing TLS certificate for the default case

    Compare with previous version

  • Micah Nagel resolved all threads

    resolved all threads

  • Ryan Garcia
  • Ryan Garcia
  • Ryan Garcia resolved all threads

    resolved all threads

  • Ryan Garcia added 1 commit

    added 1 commit

    Compare with previous version

  • Ryan Garcia resolved all threads

    resolved all threads

  • Ryan Garcia added 1 commit

    added 1 commit

    Compare with previous version

  • Ryan Garcia approved this merge request

    approved this merge request

  • Ryan Garcia changed the description

    changed the description

  • Micah Nagel approved this merge request

    approved this merge request

  • Micah Nagel changed milestone to %1.29.0

    changed milestone to %1.29.0

  • merged

  • Ryan Garcia mentioned in commit 7a7aed7a

    mentioned in commit 7a7aed7a

  • Please register or sign in to reply
    Loading