UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

FIXED: Allow custom omniauth provider configuration for GitLab

Merged Charles Bushong requested to merge gitlab-broader-sso-support into master
All threads resolved!

General MR

Summary

Solves issue #1088 (closed), and corrects !1382 (merged), allows GitLab SSO to be used with non-keycloak SSO (including Okta)

Relevant logs/screenshots

(Include any relevant logs/screenshots)

BB Processes

Add labels for affected packages so that they are deployed in CI as well as a status label:

Be sure to assign to yourself:

Once it is ready for review switch the status and assign reviewers:

Merge request reports

Merge request pipeline #710569 passed

Merge request pipeline passed for 16e769f0

Approved by

Merged by Micah NagelMicah Nagel 3 years ago (Mar 4, 2022 8:39pm UTC)

Pipeline #710620 passed with warnings

Pipeline passed with warnings for 23199695 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Otherwise LGTM, tested with Keycloak and all the defaults work as expected still.

  • Micah Nagel changed milestone to %1.29.0

    changed milestone to %1.29.0

  • I tested and the Keycloak SSO still works.

  • kevin.wilder added 1 commit

    added 1 commit

    Compare with previous version

  • kevin.wilder added 1 commit

    added 1 commit

    Compare with previous version

  • kevin.wilder resolved all threads

    resolved all threads

  • kevin.wilder added 1 commit

    added 1 commit

    Compare with previous version

  • Keycloak SSO still works. LGTM

    Edited by kevin.wilder
  • Micah Nagel approved this merge request

    approved this merge request

  • merged

  • Micah Nagel mentioned in commit 23199695

    mentioned in commit 23199695

  • Please register or sign in to reply
    Loading