Removed promtail condition from Loki values check
General MR
Summary
Current BB values cause Loki to be deployed if Promtail is enabled, even when Loki itself is configured with enabled: false. There are use cases which require standalone deployments of Promtail, which makes this an undesirable behavior.
Merge request reports
Activity
requested review from @rob.ferguson
assigned to @ablanchard
added 171 commits
-
a5f6ff67...01cdb0fd - 170 commits from branch
master - 8f06084e - Removed promtail condition from Loki values check
-
a5f6ff67...01cdb0fd - 170 commits from branch
added statusreview label
added community-contribution label
Resolved by Micah Nagel@ablanchard Can you elaborate on a scenario when promtail would be deployed without loki? This is not really a documented/required use case for that within BigBang at the moment.
- Last reply by Micah Nagel
- Resolved by Micah Nagel
One thing that will be necessary at minimum before this is good to go is adjusting conditionals across all the Loki files in this directory - https://repo1.dso.mil/platform-one/big-bang/bigbang/-/tree/bugfix/loki-deployment-conditionals/chart/templates/logging/loki
The single change you have made would still mean the gitrepo, hr, etc deploy, just without the values secret.
- Last reply by Andrew Blanchard
added 1 commit
- bc3f8498 - Removing additional promtail conditionals in the loki templates
added statusdoing label and removed statusreview label
@ablanchard This merge request is not marked as draft, if it is ready for review please add the label, statusreview.
added needs-labels label
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
-
@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.
