UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

Add /etc/hosts file entries for other apps and keycloak's NodeHosts entry in coredns (technically this is a doc update)

Merged Brendon Lloyd requested to merge k3d-dev-sh-update into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Brendon Lloyd resolved all threads

    resolved all threads

  • Brendon Lloyd added 1 commit

    added 1 commit

    • ea2bf62f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Author Contributor

    Thanks Micah. I just noticed a few more things I could add, so I am taking this out of review and will put it back soon.

  • removed statusreview label

  • Brendon Lloyd added 2 commits

    added 2 commits

    • 5c6aa367 - Add shell scripting for adding keycloak's NodeHosts entry to coredns's...
    • 454be58e - Merge branch 'k3d-dev-sh-update' of...

    Compare with previous version

  • Brendon Lloyd changed title from Add /etc/hosts file entries for other apps (technically this is a doc update) to Add /etc/hosts file entries for other apps and keycloak's NodeHosts entry in coredns (technically this is a doc update)

    changed title from Add /etc/hosts file entries for other apps (technically this is a doc update) to Add /etc/hosts file entries for other apps and keycloak's NodeHosts entry in coredns (technically this is a doc update)

  • removed statusreview label

  • @blloyd This merge request is not marked as draft, if it is ready for review please add the label, statusreview.

  • Brendon Lloyd marked this merge request as draft

    marked this merge request as draft

  • Brendon Lloyd added 1 commit

    added 1 commit

    • 10e8df93 - Relocate coredns configmap update

    Compare with previous version

  • Brendon Lloyd marked this merge request as ready

    marked this merge request as ready

  • Brendon Lloyd added 14 commits

    added 14 commits

    • 10e8df93...f8018f57 - 10 commits from branch master
    • cf3ad700 - Add /etc/hosts file entries for other apps (technically this is a doc update)
    • 58e0db34 - Add shell scripting for adding keycloak's NodeHosts entry to coredns's...
    • 817e0047 - Apply 1 suggestion(s) to 1 file(s)
    • 0239cf89 - Relocate coredns configmap update

    Compare with previous version

  • Micah Nagel
  • Micah Nagel requested review from @kevin.wilder

    requested review from @kevin.wilder

  • Brendon Lloyd resolved all threads

    resolved all threads

  • Brendon Lloyd added 1 commit

    added 1 commit

    • 7b2d7011 - Don't need absolute path for kubectl

    Compare with previous version

  • Really glad this script is getting more adoption by the BB team. Some really good contributions are happening.

  • Brendon Lloyd added 1 commit

    added 1 commit

    • 1fcdbd95 - Run kubectl remotely instead of locally

    Compare with previous version

  • Brendon Lloyd resolved all threads

    resolved all threads

  • Otherwise LGTM if it looks good to Kevin!

  • Brendon Lloyd added 1 commit

    added 1 commit

    • 951f80c8 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Brendon Lloyd added 1 commit

    added 1 commit

    • 7809dc7e - Update docs/developer/aws-k3d-script.md

    Compare with previous version

  • Brendon Lloyd resolved all threads

    resolved all threads

  • Ryan Garcia approved this merge request

    approved this merge request

  • merged

  • Ryan Garcia mentioned in commit 81f94996

    mentioned in commit 81f94996

  • Please register or sign in to reply
    Loading