Extends Big Bang using Values

Package Merge Request

Changes

Adds Helm templating to extend BB using values for mission apps. This is a proof of concept and should not change the behavior of the current chart. Additional issues will be opened to scope out the remaining work for releasing this in BB 2.0.

Areas that require extra review: _helpers.tpl changes; Making sure all new files will NOT generate anything using existing Big Bang 1.x values.

A values2.0.yaml was added that can be used for dev testing.

For Issue

Closes #1359 (closed)

added statusdoing label

assigned to @michaelmcleroy

marked this merge request as draft

added 21 commits

• 57cc224e...3561160a - 20 commits from branch master
• 0329b716 - feat: initial extenders

Compare with previous version

marked this merge request as ready

added statusreview label and removed statusdoing label

requested review from @micah.nagel, @BrandenCobb, @ryan.thompson.44, @rob.ferguson, and @ryan.j.garcia

removed review request for @micah.nagel

requested review from @micah.nagel

@michaelmcleroy Can we get a doc somewhere or maybe I'm just misunderstanding, but I filled in packages.sample to be harbor which is a third-party/sandbox package that runs with integrations to BigBang:

packages:
  # -- Package name.  Each package will be independently wrapped for Big Bang integration.
  # @default -- Uses `defaults/<package name>.yaml` for defaults.  See `package` Helm chart for additional values that can be set.
  harbor:
    # -- Toggle deployment of this package
    # @default -- true
    enabled: true
    # -- Use a kustomize deployment rather than Helm
    kustomize: false

    git:
      # -- (Required) Git repo URL holding the helm chart for this package
      repo: https://repo1.dso.mil/platform-one/big-bang/apps/sandbox/harbor.git
      # -- Git tag to check out.  Takes precedence over branch. [More info](https://fluxcd.io/flux/components/source/gitrepositories/#reference)
      tag: "1.10.1-bb.3"
      # -- Path inside of the git repo to find the helm chart or kustomize
      # @default -- For Helm charts `chart`.  For Kustomize `/`.
      path: chart

And running helm upgrade -i bigbang chart/ -f chart/values.yaml -f chart/values2.0.yaml I get:

Error: UPGRADE FAILED: template: bigbang/templates/package/values.yaml:5:73: executing "bigbang/templates/package/values.yaml" at <from
Yaml>: wrong type for value; expected map[string]interface {}; got interface {}

added 1 commit

• 8fe61ed5 - fix: package without a default file

Compare with previous version

added 29 commits

• 8fe61ed5...567fba12 - 28 commits from branch master
• 2a7cb189 - Merge branch 'master' into omnibang

Compare with previous version

New to squish.

  Warning  error   34s   helm-controller  Helm install failed: error while running post render on files: missing metadata.name in object {{security.istio.io/v1beta1 PeerAuthentication} {{ } map[app.kubernetes.io/instance:podinfo-wrapper app.kubernetes.io/managed-by:Helm app.kubernetes.io/name: app.kubernetes.io/version:0.0.0_a2419e8eb755 helm.sh/chart:bigbang-wrapper-0.0.0_a2419e8eb755] map[]}}

Should be reproducible with:

packages:
  podinfo:
    enabled: true
    git:
      repo: https://github.com/stefanprodan/podinfo.git
      tag: "6.2.3"
      path: "charts/podinfo"

added 1 commit

• eb89c83c - fix: wrapper needs name of package

Compare with previous version

Next error I'm seeing, if using monitoring and relying on the default selector creation:

  Warning  error   5s (x5 over 23s)  helm-controller  Helm install failed: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(NetworkPolicy.spec.podSelector): invalid type for io.k8s.apimachinery.pkg.apis.meta.v1.LabelSelector: got "array", expected "map"

From https://repo1.dso.mil/platform-one/big-bang/apps/wrapper/-/blob/main/chart/templates/network/networkpolicy-metrics.yaml#L3 it looks like the default selector becomes a list, but should be a map.

resolved all threads

resolved all threads

added 1 commit

• bf1713dc - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version