Update HPA logic for Istio
All threads resolved!
All threads resolved!
Package Merge Request
Package Changes
According to the issue here, AWS does a poorly job with versioning scheme, which impacts users running AWS-EKS-1.25+. Therefore, {{- if (semverCompare ">=1.23" .Capabilities.KubeVersion.GitVersion) }}
does not get read and HPA for Istio is being skipped.
Solution:
Changed
{{- if (semverCompare ">=1.23" .Capabilities.KubeVersion.GitVersion) }}
to:
{{- if .Capabilities.APIVersions.Has "autoscaling/v2" -}}
Package MR
(Link to Package MR here)
For Issue
Closes (link to issue here)
Edited by Hitesh Sharma
Merge request reports
Activity
added statusreview label
added 69 commits
-
ef7cc183...dd3cd0cc - 68 commits from branch
master
- d1ee6f30 - Merge branch 'master' into hsharma-hpa-istio-fix
-
ef7cc183...dd3cd0cc - 68 commits from branch
added istio label
assigned to @hsharma
requested review from @micah.nagel and @ryan.j.garcia
- Resolved by Micah Nagel
changed milestone to %2.0.0
enabled an automatic merge when the pipeline for ceee4b87 succeeds
mentioned in commit 64d39b31
Please register or sign in to reply