UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

Update HPA logic for Istio

Merged Hitesh Sharma requested to merge hsharma-hpa-istio-fix into master
All threads resolved!

Package Merge Request

Package Changes

According to the issue here, AWS does a poorly job with versioning scheme, which impacts users running AWS-EKS-1.25+. Therefore, {{- if (semverCompare ">=1.23" .Capabilities.KubeVersion.GitVersion) }} does not get read and HPA for Istio is being skipped.

image

Solution:

Changed

{{- if (semverCompare ">=1.23" .Capabilities.KubeVersion.GitVersion) }}

to:

{{- if .Capabilities.APIVersions.Has "autoscaling/v2" -}}

Package MR

(Link to Package MR here)

For Issue

Closes (link to issue here)

Edited by Hitesh Sharma

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Micah Nagel resolved all threads

    resolved all threads

  • Micah Nagel added 1 commit

    added 1 commit

    • ceee4b87 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Micah Nagel changed milestone to %2.0.0

    changed milestone to %2.0.0

  • Micah Nagel approved this merge request

    approved this merge request

  • Micah Nagel enabled an automatic merge when the pipeline for ceee4b87 succeeds

    enabled an automatic merge when the pipeline for ceee4b87 succeeds

  • merged

  • Micah Nagel mentioned in commit 64d39b31

    mentioned in commit 64d39b31

  • Please register or sign in to reply
    Loading