UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

add support for Gitlab rails secret creation SKIP CHECK CHANGES SKIP UPGRADE

All threads resolved!

General MR

Please let me know what changes I need to make here! I'm more than willing to work with whomever to bring this MR up to snuff.

Summary

Adds support for the specification of the railsSecret content directly in the BigBang Chart

Reasoning: BigBang allows for the specification of things like the SSO credentials, the redis credentials, and the database credentials. However we cannot specify the contents of the rails Secret directly. Instead, we have to either have the Gitlab chart create the rails secret for us and then back that up, create a kube manifest and then add that to the Bigbang kustomization. This is a messy process and can be very annoying when spinning up blue/green clusters, or even test clusters used to validate things like Gitlab backups (because the rails secrets need to match)

Instead, it would be very handy to be able to specify the contents of the gitlab rails secret directly in the BigBang gitlab addon values. This would allow us to spin up new BigBang clusters that are ready to accept Gitlab-backup restores from another cluster very smoothly. It would also fit inline with how BigBang is handling other Gitlab secrets.

This is a first draft of this MR. If there is anything different you'd like to see please let me know! I am reachable in chat.il4.dso.mil as nicholas.wilburn.1.ctr and would be more than happy to discuss this here or there.

Merge request reports

Merge request pipeline #1703534 passed

Merge request pipeline passed for fb05d1df

Approved by

Merged by Ryan GarciaRyan Garcia 1 year ago (Apr 27, 2023 2:53pm UTC)

Merge details

  • Changes merged into master with 9d6736fc (commits were squashed).
  • Deleted the source branch.

Pipeline #1706415 passed

Pipeline passed for 9d6736fc on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The rails secret looks for a key secrets.yml and in order for it to be accepted and templated correctly someone would need to paste in the already base64 encoded string since under this key there are 5 keys which all have data. Will see about testing this in restoring a dev cluster in the next couple days.

  • Nicholas Wilburn resolved all threads

    resolved all threads

  • Nicholas Wilburn resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Micah Nagel changed title from Draft: add support for Gitlab rails secret creation to Draft: add support for Gitlab rails secret creation SKIP CHECK CHANGES

    changed title from Draft: add support for Gitlab rails secret creation to Draft: add support for Gitlab rails secret creation SKIP CHECK CHANGES

  • added gitlab label

  • Micah Nagel
  • Micah Nagel
  • Micah Nagel
  • added 1 commit

    • 23137ee5 - change to gitlab.railsSecret

    Compare with previous version

  • added 1 commit

    • 2ad18791 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    • 4041fbf0 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ryan Garcia changed milestone to %2.1.0

    changed milestone to %2.1.0

  • Ryan Garcia marked this merge request as ready

    marked this merge request as ready

  • Ryan Garcia changed title from Draft: add support for Gitlab rails secret creation SKIP CHECK CHANGES to add support for Gitlab rails secret creation SKIP CHECK CHANGES SKIP UPGRADE

    changed title from Draft: add support for Gitlab rails secret creation SKIP CHECK CHANGES to add support for Gitlab rails secret creation SKIP CHECK CHANGES SKIP UPGRADE

  • Ryan Garcia requested review from @ryan.j.garcia

    requested review from @ryan.j.garcia

  • Nicholas Wilburn resolved all threads

    resolved all threads

  • added 1 commit

    • fb05d1df - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ryan Garcia approved this merge request

    approved this merge request

  • merged

  • Ryan Garcia mentioned in commit 9d6736fc

    mentioned in commit 9d6736fc

  • Ryan Garcia mentioned in merge request !2715 (merged)

    mentioned in merge request !2715 (merged)

  • Please register or sign in to reply
    Loading