add support for Gitlab rails secret creation SKIP CHECK CHANGES SKIP UPGRADE
General MR
Please let me know what changes I need to make here! I'm more than willing to work with whomever to bring this MR up to snuff.
Summary
Adds support for the specification of the railsSecret content directly in the BigBang Chart
Reasoning: BigBang allows for the specification of things like the SSO credentials, the redis credentials, and the database credentials. However we cannot specify the contents of the rails Secret directly. Instead, we have to either have the Gitlab chart create the rails secret for us and then back that up, create a kube manifest and then add that to the Bigbang kustomization. This is a messy process and can be very annoying when spinning up blue/green clusters, or even test clusters used to validate things like Gitlab backups (because the rails secrets need to match)
Instead, it would be very handy to be able to specify the contents of the gitlab rails secret directly in the BigBang gitlab addon values. This would allow us to spin up new BigBang clusters that are ready to accept Gitlab-backup restores from another cluster very smoothly. It would also fit inline with how BigBang is handling other Gitlab secrets.
This is a first draft of this MR. If there is anything different you'd like to see please let me know! I am reachable in chat.il4.dso.mil as nicholas.wilburn.1.ctr
and would be more than happy to discuss this here or there.
Merge request reports
Activity
added statusreview label
- Resolved by Nicholas Wilburn
- Resolved by Micah Nagel
The rails secret looks for a key
secrets.yml
and in order for it to be accepted and templated correctly someone would need to paste in the already base64 encoded string since under this key there are 5 keys which all have data. Will see about testing this in restoring a dev cluster in the next couple days.added gitlab label
- Resolved by Micah Nagel
Looks like our CI was not prepared for running off of a fork, so I added a skip of the broken stage. That should get this unblocked.
- Automatically resolved by Nicholas Wilburn
- Automatically resolved by Nicholas Wilburn
- Automatically resolved by Nicholas Wilburn
- Resolved by Ryan Garcia
Are there any tests I should add for this? Where would those be located?
- Resolved by Nicholas Wilburn
- Resolved by Nicholas Wilburn
- Resolved by Ryan Garcia
Can maybe do this as a follow-on since we can't directly commit to this branch but also will need to update this document:
changed milestone to %2.1.0
- Resolved by Nicholas Wilburn
requested review from @ryan.j.garcia
requested review from @micah.nagel, @rob.ferguson, and @ryan.thompson.44
mentioned in commit 9d6736fc
mentioned in merge request !2715 (merged)