UNCLASSIFIED - NO CUI

Skip to content

Allow seamless sidecar cycling for enterprise Istio switch

Micah Nagel requested to merge micah.nagel-master-patch-10161 into master

General MR

Summary

When I switch from non-enterprise istio to enterprise istio I would like all of my sidecars to cycle as well. This does not currently happen since the istio version annotations just have a numerical version.

Proposal in this PR would be to conditionally add a -enterprise to the annotation if using TID. This would cause a one-time cycling of all sidecars for anyone using TID currently - if that is not desirable this could be held off until the next time TID is updating, which would prevent unnecessary cycling.

Also worth noting, when the TID version does not line up with the chart version this logic is still not perfect since it could cause unnecessary cycling.

Edited by Micah Nagel

Merge request reports