Allow seamless sidecar cycling for enterprise Istio switch

General MR

Summary

When I switch from non-enterprise istio to enterprise istio I would like all of my sidecars to cycle as well. This does not currently happen since the istio version annotations just have a numerical version.

Proposal in this PR would be to conditionally add a -enterprise to the annotation if using TID. This would cause a one-time cycling of all sidecars for anyone using TID currently - if that is not desirable this could be held off until the next time TID is updating, which would prevent unnecessary cycling.

Also worth noting, when the TID version does not line up with the chart version this logic is still not perfect since it could cause unnecessary cycling.

added istio statusreview labels

assigned to @micah.nagel

changed the description

A few comments/questions in the description - not sure what the team would see as the most desirable path forward here, but the TLDR of the issue is that TID image rotation is not handled in an effective way currently.

requested review from @ryan.thompson.44, @chris.oconnell, and @ryan.j.garcia

changed milestone to %2.5.0

added community-contribution label

changed milestone to %2.6.0

added 72 commits

• d5c5ae48...9e2c6b08 - 70 commits from branch master
• dd5ca780 - Allow seamless sidecar cycling for enterprise Istio switch
• 3ebbd438 - Merge branch 'micah.nagel-master-patch-10161' of...

Compare with previous version

Rebased to test locally with 1.17.2 > 1.17.3 upgrade and I like this approach and think we can pull it in for the next upgrade of enterprise images.

@chris.oconnell @ryan.thompson.44 Any thoughts?

changed milestone to %2.7.0

added needs-attention label

mentioned in issue #1592

approved this merge request

resolved all threads

mentioned in commit 34d3fb2a

merged