UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

feat: configure gitlab groups from external oidc groups

Merged Noah Birrer requested to merge feat/gitlab-oidc-group-members into master
All threads resolved!

General MR

Summary

This Merge Request adds the ability to configure GitLab users based on OIDC group membership. The impacted config is the gitlab-sso-provider secret that is deployed alongside the GitLab HelmRelease.

The following values can now be included in addons.gitlab.sso:

groups:
  groupsAttribute: ""
  requiredGroups: []
  externalGroups: []
  auditorGroups: []
  adminGroups: []

This addition is backwards compatible. If a user does not supply any groups in their GitLab values, the gitlab-sso-provider secret will still render a valid JSON object.

NOTE: That this is only a GitLab premium/ultimate feature.

Relevant logs/screenshots

GitLab Docs on configuring external groups - ref

Linked Issue

issue

Upgrade Notices

N/A

Edited by Noah Birrer

Merge request reports

Merge request pipeline #2868970 passed with warnings

Merge request pipeline passed with warnings for 8a76404c

Approved by

Merged by Ryan GarciaRyan Garcia 1 year ago (Feb 15, 2024 10:29pm UTC)

Merge details

Pipeline #2873515 failed

Pipeline failed for 2a9cd6c3 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Ryan Garcia

      Thanks for working this @noahbirrer I would like to re-work that comment to read a bit better and start with the formatting in the comment above. If you go off other SSO or extra values provided by a package we usually only have a 1 sentence blurb and a ref to upstream documentation so as not to add clutter to the values file.

  • @andrewshoell : You have been tagged in this merge request for the purpose of conducting secondary review.

  • Noah Birrer added 1 commit

    added 1 commit

    • 7a340ae2 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Noah Birrer added 1 commit

    added 1 commit

    Compare with previous version

  • Noah Birrer added 3 commits

    added 3 commits

    Compare with previous version

  • Ryan Garcia added 1 commit

    added 1 commit

    • 2f9107c6 - gitlab.sso.groups comment rendering

    Compare with previous version

  • Noah Birrer added 1 commit

    added 1 commit

    • 07b1210e - metricsServer update to 3.11.0-bb.3

    Compare with previous version

  • Noah Birrer added 3 commits

    added 3 commits

    Compare with previous version

  • Ryan Garcia approved this merge request

    approved this merge request

  • Ryan Garcia resolved all threads

    resolved all threads

  • merged

  • Ryan Garcia mentioned in commit 2a9cd6c3

    mentioned in commit 2a9cd6c3

  • Please register or sign in to reply
    Loading