Thanos exposed objstoreConfig removed in favor of values overrides

Package Merge Request

Package Changes

Remove nesting objstoreConfig under addons.thanos

Package MR

(Link to Package MR here)

For Issue

Closes #1964 (closed)

Upgrade Notices

objstoreConfig was removed from addons.Thanos.objstoreConfig . To use a custom objstoreConfig for Thanos, the package values passthrough method can be defined:

addons:
  thanos:
    values:
      objstoreConfig: |-
        type: s3
        config:
          bucket: "thanos"
          endpoint: minio.thanos.svc.cluster.local:80
          ...

added statusdoing thanos labels

assigned to @staskiewicz.blane

changed title from Draft: Thanos objstoreConfig moved to under thanos to Draft: Thanos objstoreConfig moved under thanos

added 1 commit

• 84763618 - revert to subchart settings

Compare with previous version

added 1 commit

• 0fc0ced1 - rm comments

Compare with previous version

changed title from Draft: Thanos objstoreConfig moved under thanos to Draft: Thanos objstoreConfig moved under thanos values

changed the description

we decided to remove the objstoreConfig value at the bigbang level.

objstoreConfig is simply passed through -- there is no extra parsing or bigbang specific settings used there, so we should be able set and pass this through using e.g.

addons:
  thanos:
    values:
      objstoreConfig: |-
        type: s3
        config:
          bucket: "thanos"
          endpoint: minio.thanos.svc.cluster.local:80
          ...

marked this merge request as ready

added statusreview label and removed statusdoing label

requested review from @ryan.j.garcia, @michaelmartin, and @chris.oconnell

approved this merge request

changed title from Thanos objstoreConfig moved under thanos values to Thanos exposed objstoreConfig removed in favor of values overrides

changed milestone to %2.22.0

approved this merge request

approved this merge request

merged

mentioned in commit ac179b78

changed the description

added thanos label