Resolve "TLS configuration is invalid with custom TCP ports"

Package Merge Request

Package Changes

adds a conditional to check tlsMode

Package MR

(Link to Package MR here)

For Issue

Closes 1680

Upgrade Notices

"N/A"

Closes #1680 (closed)

added community-contribution istio kindbug priority3 statusdoing teamService Mesh labels

assigned to @stephen.galamb

changed the description

added 1 commit

• d0c5d282 - conditional added

Compare with previous version

added statusreview label and removed statusdoing label

marked this merge request as ready

changed the description

removed statusreview label

@stephen.galamb This merge request is not marked as draft, if it is ready for review please add the label, statusreview.

added needs-labels label

added 144 commits

• d0c5d282...9cb3134d - 134 earlier commits
• fb4638c1 - monitoring update to 57.2.0-bb.1
• 34a35744 - anchore update to 2.4.2-bb.5
• bad8b369 - Developer documentation updates & refresh
• 6ab90662 - Update README, to include quick start guide in "Getting Started"
• 1229816e - anchore update to 2.4.2-bb.6
• 19b63beb - kiali update to 1.82.0-bb.2
• 7f2be32a - Resolve "Ensure that istio.hardened.enabled is turned on for all packages in...
• 0fc5efff - minio update to 5.0.12-bb.10
• c0664e3c - Update ElasticSearchKibana to 1.12.0-bb.1
• 9a55ef91 - Adding harbor to default-creds.md

Compare with previous version

added statusreview label

removed needs-labels label

I tried installing the BB helm chart on master branch with these values:

istio:
  gateways:
    public:
      ports:
        - name: https
          number: 8443
          protocol: HTTPS
        - name: tcp-custom-will-it-break
          number: 7687
          protocol: TCP

And it succeeded, despite having a non HTTPS port that the chart gives a tls property. For thoroughness, I installed once and then upgraded twice.

As I was unable to reproduce the problem, I will close this MR.

closed