UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

Adding OpenShift Test Values

Merged Aaron Lieberman requested to merge openshift-test-values into master

Package Merge Request

Package Changes

Adding test values for OpenShift nightly pipeline

Upgrade Notices

N/A

Edited by Michael Martin

Merge request reports

Merge request pipeline #3297320 passed

Merge request pipeline passed for 1a23e230

Approved by

Merged by Michael MartinMichael Martin 10 months ago (May 24, 2024 1:16pm UTC)

Merge details

  • Changes merged into master with fa4bc222 (commits were squashed).
  • Deleted the source branch.

Pipeline #3307098 passed

Pipeline passed for fa4bc222 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @ryan.thompson.44 and @michaelmartin

  • @andrewshoell : You have been tagged in this merge request for the purpose of conducting secondary review.

  • Aaron Lieberman resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

    • Resolved by Jeffrey Victor

      @alieberman @chris.oconnell

      This file seems like a full copy of the default test-values.yaml . This is different than e.g. tests/rke2-test-values.yaml which is a general overrides file.

      How will this file be maintained ? It will be difficult if we need to maintain/keep-in-sync both tests/test-values.yaml and tests/openshift-test-values.yaml .

      Can this file be a general "overrides" file similar to tests/rke2-test-values.yaml ?

      Edited by Michael Martin
  • Jimmy Bourque added statusdoing label and removed statusreview label

    added statusdoing label and removed statusreview label

  • James Causey added 1 commit

    added 1 commit

    Compare with previous version

  • updated OS values file, removing dup code from test-values

  • James Causey added statusreview label and removed statusdoing label

    added statusreview label and removed statusdoing label

  • Jeffrey Victor resolved all threads

    resolved all threads

  • Jeffrey Victor approved this merge request

    approved this merge request

  • Jeffrey Victor unapproved this merge request

    unapproved this merge request

  • Jimmy Bourque
  • Jimmy Bourque
  • Jimmy Bourque
  • James Causey added 1 commit

    added 1 commit

    Compare with previous version

  • James Causey resolved all threads

    resolved all threads

  • James Causey added 1 commit

    added 1 commit

    Compare with previous version

  • added 201 commits

    Compare with previous version

  • added 1 commit

    • 591c5200 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 608f518c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 9d969c49 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • b96f9792 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Michael Martin changed the description

    changed the description

  • Michael Martin
  • Michael Martin
  • Michael Martin
  • Michael Martin
  • I wasn't sure on those domain name changes? Seem at one point, the domain was changed, but now it would be using dev.bigbang.mil from test-values.yaml . If we are using dev.bigbang.mil, I think you can just remove the overrides.

  • added 3 commits

    Compare with previous version

  • added 1 commit

    • 26c57d33 - Removing duplicated config from OS test values

    Compare with previous version

  • James Causey
  • James Causey
  • added 1 commit

    Compare with previous version

  • Michael Martin resolved all threads

    resolved all threads

  • look good to me -- clean and simple overrides now for openshift. I don't have a way to test, but looks good for initial cut.

    Edited by Michael Martin
  • Michael Martin changed milestone to %2.28.0

    changed milestone to %2.28.0

  • Michael Martin approved this merge request

    approved this merge request

  • mentioned in commit fa4bc222

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading