UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

fix(istio): Add line to allow enabling/disabling individual ingress gateways

Merged Christopher Kyle Galloway requested to merge service-mesh/no-flags-ingress-bug-fix into master
All threads resolved!

Bug Fix

Description

Previously, if running using the tests/test-values.yaml with k3d-dev.sh and no flags, an behavior would sometimes occur that would assign all of the k3d/docker IP addresses to the passthrough-ingressgateway LoadBalancer service that is created using the test-values.yaml and assign none of the IP addresses to the public-ingressgateway LoadBalancer service. This would make the public-ingressgateway LoadBalancer service end up in a state and never be able to be used by incoming traffic. This was only occasionally seen since it is an undefined race condition (k3d/k3s doesn't define the behavior when deploying multiple LoadBalancers to the same cluster without using MetalLB).

This MR adds a line to allow passing enabled status for individual ingress gateways in istio. This would allow users/devs to turn off the extra passthrough-ingressgateway LoadBalancer service if they do not need it and are not running with MetalLB (e.g. using k3d-dev.sh with no flags).

For Issue

Closes 2118

Upgrade Notices

N/A

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 49 commits

    Compare with previous version

  • added 5 commits

    Compare with previous version

  • resolved all threads

  • added 1 commit

    Compare with previous version

  • requested review from @andrewshoell

  • test different values and working for me

  • Michael Martin approved this merge request

    approved this merge request

  • Michael Martin resolved all threads

    resolved all threads

  • mentioned in commit 53b1c2bb

  • Michael Martin changed milestone to %2.29.0

    changed milestone to %2.29.0

  • mentioned in issue #2118 (closed)

  • Please register or sign in to reply
    Loading