UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

dig some values in case the values are not set

Merged Michael Martin requested to merge fix-thanos-values into master
All threads resolved!

General MR

Summary

We needed a few more digs to handle optional values in Thanos

This pulls in the changes from this MR which had been reverted and adds a few more digs to allow install without passing in test-values.yaml : !4957 (merged)

TEST RESULTS:

Without passing in test-values.yaml
$ kubectl get pod -n thanos -L app,version
NAME                                     READY   STATUS    RESTARTS   AGE   APP      VERSION
thanos-query-677fbdff8c-b99tz            2/2     Running   0          73s   thanos   v0.36.1
thanos-query-frontend-544495d8b6-6f5dq   2/2     Running   0          73s   thanos   v0.36.1
With test-values.yaml passed in
$ kubectl get pod -n thanos -L app,version
NAME                                     READY   STATUS    RESTARTS   AGE     APP      VERSION
thanos-compactor-6cc65c5656-8rmlp        2/2     Running   0          66s     thanos   v0.36.1
thanos-minio-pool-0-0                    3/3     Running   0          55s     minio    
thanos-query-6666545dd9-8g55s            2/2     Running   0          66s     thanos   v0.36.1
thanos-query-frontend-544495d8b6-6f5dq   2/2     Running   0          7m13s   thanos   v0.36.1
thanos-storegateway-0                    2/2     Running   0          66s     thanos   v0.36.1

Upgrade Notices

N/A

Edited by Michael Martin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andrew Shoell marked this merge request as draft

    marked this merge request as draft

  • Andrew Shoell added statusdoing label and removed statusreview label

    added statusdoing label and removed statusreview label

  • Michael Martin resolved all threads

    resolved all threads

  • Michael Martin added 66 commits

    added 66 commits

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Michael Martin marked this merge request as ready

    marked this merge request as ready

  • Michael Martin added statusreview label and removed statusdoing label

    added statusreview label and removed statusdoing label

  • Michael Martin changed the description

    changed the description

  • Andrew Shoell approved this merge request

    approved this merge request

  • Michael Martin mentioned in commit a9d8a4c3

    mentioned in commit a9d8a4c3

  • Please register or sign in to reply
    Loading