dig some values in case the values are not set
All threads resolved!
All threads resolved!
General MR
Summary
We needed a few more digs to handle optional values in Thanos
This pulls in the changes from this MR which had been reverted and adds a few more digs to allow install without passing in test-values.yaml
: !4957 (merged)
TEST RESULTS:
Without passing in test-values.yaml
$ kubectl get pod -n thanos -L app,version
NAME READY STATUS RESTARTS AGE APP VERSION
thanos-query-677fbdff8c-b99tz 2/2 Running 0 73s thanos v0.36.1
thanos-query-frontend-544495d8b6-6f5dq 2/2 Running 0 73s thanos v0.36.1
With test-values.yaml passed in
$ kubectl get pod -n thanos -L app,version
NAME READY STATUS RESTARTS AGE APP VERSION
thanos-compactor-6cc65c5656-8rmlp 2/2 Running 0 66s thanos v0.36.1
thanos-minio-pool-0-0 3/3 Running 0 55s minio
thanos-query-6666545dd9-8g55s 2/2 Running 0 66s thanos v0.36.1
thanos-query-frontend-544495d8b6-6f5dq 2/2 Running 0 7m13s thanos v0.36.1
thanos-storegateway-0 2/2 Running 0 66s thanos v0.36.1
Upgrade Notices
N/A
Edited by Michael Martin
Merge request reports
Activity
changed milestone to %2.36.0
added statusreview thanos labels
requested review from @chris.oconnell and @andrewshoell
assigned to @michaelmartin
added 5 commits
-
dad191f6...d6260a8a - 4 commits from branch
master
- 68d027d3 - Merge remote-tracking branch 'origin/master' into fix-thanos-values
-
dad191f6...d6260a8a - 4 commits from branch
requested review from @troymobley and @cbowmanclare
changed milestone to %2.37.0
- Resolved by Michael Martin
added statusdoing label and removed statusreview label
added 66 commits
-
68d027d3...181e2a02 - 64 commits from branch
master
- 45473b26 - Merge remote-tracking branch 'origin/master' into fix-thanos-values
- 4472aca2 - removed minio check
-
68d027d3...181e2a02 - 64 commits from branch
added statusreview label and removed statusdoing label
mentioned in commit a9d8a4c3
Please register or sign in to reply