nexusRepositoryManager update to 72.0.0-bb.1
Package Merge Request
Package Changes
https://repo1.dso.mil/big-bang/product/packages/nexus/-/blob/72.0.0-bb.1/CHANGELOG.md
Package MR
big-bang/product/packages/nexus!193 (merged)
For Issue
Closes big-bang/product/packages/nexus#145 (closed)
Upgrade Notices
N/A
Merge request reports
Activity
added botmr nexusRepositoryManager statusdoing labels
assigned to @nbazzeghin
requested review from @chris.oconnell, @michaelmartin, and @andrewshoell
added statusreview label and removed statusdoing label
changed milestone to %2.39.0
- Resolved by Michael Martin
@nbazzeghin . I like what we've done here to enable the realms on the fly.
It seems like we've re-purposed a single "sso.realm" name to now mean a "list of realms to enable" . Some realms that can be enabled --e.g.
DockerToken
-- are not sso related. So, it's confusing that would be defined under ansso
key -- especially if sso is not enabled.Could we:
- Refactor
sso.realm
to a top-levelrealms:
key. And then use the logic you added to enable the list of realms there. - Keep sso.realm to specify the "realm name" to be used by default for Big Bang SSO installs. This name would then be added to the top-level
realms:
list.
I don't think that should be too much work, but I think that would help make the values a little clearer in what's being done.
Edited by Michael Martin - Refactor
requested review from @troymobley and @cbowmanclare
mentioned in issue big-bang/product/packages/nexus#148 (closed)
mentioned in commit 16282f6a
mentioned in merge request big-bang/customers/template!107 (merged)