change the helm dependency logic to only include minio-operator if minio (tenant) is enabled

Package Merge Request

Package Changes

Fixed the logic when minio-operator is added as a helmrelease dependency. Used .Values.loki.values.minio.enabled instead of objectStorage dict.

Package MR

(Link to Package MR here)

For Issue

Closes (#1473 (closed))

Upgrade Notices

n/a

Closes #1473 (closed)

added community-contribution kindbug loki needs-labels statusdoing teamObservability labels

added debug label

changed the description

removed debug label

changed the description

assigned to @kscheunemann

requested review from @michaelmartin, @chris.oconnell, and @andrewshoell

requested review from @peter.sigur, @piotr.machaj, @blairbowden, @kliu, and @bjacksonfv

requested review from @steven.donald

marked this merge request as ready

added statusreview label and removed statusdoing label

requested review from @troymobley

added 19 commits

• b0a8ebdf...20ec6a19 - 18 commits from branch master
• 2cfa078c - Merge remote-tracking branch 'origin/master' into...

Compare with previous version

resolved all threads

added 10 commits

• 2cfa078c...441d12cb - 8 commits from branch master
• 57dcf44f - Merge remote-tracking branch 'origin/master' into...
• e60c78cf - if minioOperator is enabled then enable it as a dependency.

Compare with previous version

changed the description

changed milestone to %2.47.0

suggest we also remove this from bigbang/chart/templates/loki/values.yaml

{{- with .Values.loki.objectStorage }}
{{- if and (eq $.Values.loki.strategy "scalable") (not (and .endpoint .region)) }}
minio:
  enabled: true

{{- end }}

This way, we're not forcing Values.loki.objectStorage settings on users to enable/disable minio -- let the end user enable minio if they know they need it

added 1 commit

• 4805dc67 - remove confusing logic to enable minio-tenant

Compare with previous version