Updated deploy script to handle secrets properly
Merge request reports
Activity
added Bug Fixes label
added statusreview label
- Resolved by Micah Nagel
/cc @kevin.wilder
I don't really know how to test this...but this is where the fix is needed. Because we use flux/gitops to deploy these secrets the sed commands I messing with here are really what control the branch for the secrets being deployed. There might be a better way to check if we're on an
upgrade
stage on the master branch but this is what came to mind since we do the checkout of the branch....
changed milestone to %1.13.0
Micah and I discussed using
git rev-parse HEAD
to get the commit currently checked out on the system and replacingbranch: master
withcommit: <sha>
. This would help simplify the code. But since the work is done, it is not worth the effort to refactor. If we ever need to touch this code again, we can consider it then.mentioned in commit 2176c5b9