Allow for easier flux airgap update

Problem

Airgapped users have a hard time updating and installing flux on their networks. Part of this reason is because the install_flux.sh script assumes registry1.dso.mil is the registry, always.

Solution

Set default registry to registry1.dso.mil, but add an argument for users to provide their own specific registry url/ip:port.

#661 (closed)

changed the description

requested review from @ryan.j.garcia

I like that the diff is small.

testing shows it works and is backwards compatible

git clone https://repo1.dso.mil/platform-one/big-bang/bigbang.git
cd bigbang
git checkout flux-airgap-update
./scripts/install_flux.sh -u testuser -p testpass -r clonedregistry.lan

Verifying new behavior:
k get secret -n=flux-system private-registry -o yaml | grep .dockerconfigjson: | cut -d " " -f 4 | base64 -d

{"auths":{"clonedregistry.lan":{"username":"testuser","password":"testpass","auth":"dGVzdHVzZXI6dGVzdHBhc3M="}}}

Verifying backwards compatibility:
./scripts/install_flux.sh -u testuser -p testpass
k get secret -n=flux-system private-registry -o yaml | grep .dockerconfigjson: | cut -d " " -f 4 | base64 -d

{"auths":{"registry1.dso.mil":{"username":"testuser","password":"testpass","auth":"dGVzdHVzZXI6dGVzdHBhc3M="}}}

approved this merge request

LGTM, ^-- the above notes should help @ryan.j.garcia quick approve

hum one sec I remember some notes I wrote let me check one more thing

ok yeah cool this edge scenario test case also looks good:
This should be safe to merge given the backwards compatibility manual smoke test (above) passed, but could you do an integration test to confirm it solves the issue:

(we still have folks doing airgap clones of IB, using registry:2 w/o HTTPS / auth listening on port 5000, which is a really old legacy method)

./scripts/install_flux.sh -u testuser -p testpass -r 10.10.10.10:5000

{"auths":{"10.10.10.10:5000":{"username":"testuser","password":"testpass","auth":"dGVzdHVzZXI6dGVzdHBhc3M="}}}

I think this could work in that scenario too, I don't have an environment setup to test it more throughly, but as long as it's pointing to the url I think it'd ignore the username and password. @cassiesouza do you think you can do some more testing of this edge case?

1. load a registry:2
2. upload flux images into registry:2
3. verify flux can pull from registry:2 listening on some IP: 5000

approved this merge request

changed title from Draft: Allow for easier flus airgap update to Draft: Allow for easier flux airgap update

approved this merge request

resolved all threads

added statusreview label

marked this merge request as ready

added BB-Air-Gap label

merged

mentioned in commit a5359281

changed milestone to %1.16.0

mentioned in issue #633 (closed)

mentioned in issue #634 (closed)